mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Down <chris@chrisdown.name>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>, Chris Li <chrisl@kernel.org>,
	Kairui Song <kasong@tencent.com>,
	Kemeng Shi <shikemeng@huaweicloud.com>,
	Nhat Pham <nphamcs@gmail.com>, Baoquan He <baoquan.he@linux.dev>,
	Barry Song <baohua@kernel.org>,
	Youngjun Park <youngjun.park@lge.com>,
	Ying Huang <huang.ying.caritas@gmail.com>,
	Kelley Nielsen <kelleynnn@gmail.com>,
	Vineeth Pillai <vineeth@bitbyteword.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH] mm: Make swapoff interruptible when unusing mms/shmem
Date: Mon, 26 Oct 2026 22:04:22 +0800	[thread overview]
Message-ID: <at9d5rD-15wXXiK8@chrisdown.name> (raw)
In-Reply-To: <b1aaff8f-c4b1-4c2c-939e-7051e7f9b6b8@linux.alibaba.com>

Hi Baolin, Andrew,

Sorry, I missed this.

Yes, I think -ERESTARTSYS is appropriate here. I used -EINTR to match the 
existing signal exit in try_to_unuse(), but that also means a freezer induced 
interruption becomes visible to userspace after thaw. Let me use ERESTARTSYS 
instead.

Re: Andrew's earlier questions: before b56a2d8af914, try_to_unuse() checked for 
signals between swap entries, rather than after walking an entire mm.  
Individual I/O waits can still delay it but certainly it's a lot better than 
this situation.

So yes, I think this probably warrants a stable backport given the suspend 
timeout is reproducible and it's a reasonable usability regression even though 
it has been present for a long time. I'll add Cc: stable for v2.

Thanks!

  reply	other threads:[~2026-10-26 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 23:17 Chris Down
2026-09-30 23:46 ` Andrew Morton
2026-10-01 12:50 ` Vineeth Remanan Pillai
2026-10-08  3:16 ` Baolin Wang
2026-10-26 14:04   ` Chris Down [this message]
2026-10-26 14:31 ` [PATCH v2] " Chris Down
2026-10-27  1:28   ` Baolin Wang
2026-10-27 11:50   ` Kairui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=at9d5rD-15wXXiK8@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=baoquan.he@linux.dev \
    --cc=chrisl@kernel.org \
    --cc=huang.ying.caritas@gmail.com \
    --cc=hughd@google.com \
    --cc=kasong@tencent.com \
    --cc=kelleynnn@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shikemeng@huaweicloud.com \
    --cc=vineeth@bitbyteword.org \
    --cc=youngjun.park@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®