Re: [PATCH 0/2] net: qrtr: don't lose name server packets behind the HELLO gate

[Manivannan Sadhasivam <mani@kernel.org>]

Hi Igor,

On Mon, Oct 19, 2026 at 01:12:00PM +0200, Igor Opaniuk wrote:
> Since commit 544d85de4dc2 ("net: qrtr: Send HELLO message on endpoint
> register") the core refuses every non-HELLO packet to a node until the
> HELLO to it has been sent, and retries a HELLO that cannot be sent yet
> 100 ms later. A freshly booted remoteproc has no glink rx intents, so
> the first HELLO fails, and the name server's announcements in that
> window (the replies to the remote's HELLO and the NEW_SERVER broadcasts
> of local servers) are dropped for good. The name server then also skips
> the lookup notifications for a server whose broadcast failed.
> 
> On QCM2290 (Arduino UNO Q) this stalls the modem in about one boot in
> five: it waits for the RMTFS service, which rmtfs registers in the same
> instant the modem starts, until its watchdog fires 40 s later; WiFi,
> whose firmware runs on the modem, comes up a minute late.
> 
> Patch 1 makes the name server carry on after a failed send (announce
> the remaining servers, notify the pending lookups). Patch 2 holds
> control packets for a node behind its HELLO and sends them right after
> it, instead of dropping them; data packets are still refused before the
> HELLO, so flow control is unchanged.
> 
> Initially tested on the Arduino UNO Q (QRB2210) with v7.3-rc6 plus the board
> support it needs: 10 fresh boots and 10 modem stop/start cycles, no
> "failed to announce new service", no modem watchdog, WLAN firmware up
> 6.4-8.2 s after boot every time; unpatched, 2/10 boots and 1/18 restarts
> stalled. Built with W=1 on net/main; applies to next-20261016.
> 
> I'm not deeply familiar with QRTR; an alternative would be to have the
> core trigger announce_servers() for the node once its HELLO is sent.
> Happy to rework it that way if preferred.
> 

Thanks for the series. There is already a patch floating [1] to fix the issue
you are trying to fix and it looks simple compared to this series.

But still, this series is useful, atleast patch 1. So you can resend this series
on top of v3 of [1] after fixing Sashiko's comments.

- Mani

[1] https://lore.kernel.org/netdev/20261022163116.1042-1-26rote@gmail.com

-- 
மணிவண்ணன் சதாசிவம்