mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Changbin Du <changbin.du@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	David Laight <david.laight.linux@gmail.com>
Subject: Re: [PATCH v4] perf bench: Add atomic operations benchmark
Date: Wed, 14 Oct 2026 21:07:16 -0700	[thread overview]
Message-ID: <atBRdE0Nh8OyWiBC@z2> (raw)
In-Reply-To: <atA7Mgrupnil4Jcv@mail.google.com>

On Thu, Oct 15, 2026 at 10:38:17AM +0800, Changbin Du wrote:
> On Wed, Oct 14, 2026 at 02:28:02PM -0700, Namhyung Kim wrote:
> > On Tue, Oct 13, 2026 at 04:56:48PM +0800, Changbin Du wrote:
> [..]
> > > +
> > > +static const struct option options[] = {
> > > +	OPT_UINTEGER('t', "threads", &threads,
> > > +		     "Number of contending threads (default: 2, or 1 on single CPU)"),
> > > +	OPT_UINTEGER('r', "runtime", &runtime,
> > 
> > Can you please pick a different short option than 'r'?  perf bench
> > itself has -r/--repeat option so it would be confusing.  It doesn't
> > clash for now, but I think it's better to use perf bench options from
> > 'perf bench atomic ...' later.
> > 
> 
> Agreed -- I'll drop the short options; --threads and --runtime
> stay long-only so no bench option (e.g. -r/--repeat) is shadowed
> at perf bench atomic .... Will send an updated patch.

Well.. but short options are easier to use.  I think you can use 'R' and
'T' instead.

Thanks,
Namhyung


      reply	other threads:[~2026-10-15  4:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13  8:56 Changbin Du
2026-10-14 21:28 ` Namhyung Kim
2026-10-15  2:38   ` Changbin Du
2026-10-15  4:07     ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atBRdE0Nh8OyWiBC@z2 \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=changbin.du@gmail.com \
    --cc=david.laight.linux@gmail.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®