From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C643509EE5 for ; Thu, 15 Oct 2026 10:32:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792060346; cv=none; b=ETkYb/498EsZ1FQOL2v4IdmdxqlLa4xWOVuH755VbL/dpHzpN4R9ZMGA1GH7NW7NUhfGmM3X9EewNu4iqsrqlG2rrPt9qMDl8Yn68SGuTpYcF2tRhArjFrhAIWJp6ot9rgJO9Z3RSP6F+sYeq2h/TDQouQ4UAtMCbkdroi4FTXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792060346; c=relaxed/simple; bh=BwzEGGlN0Cr4GFybOAnQmDAQNaVFm68oam3tFIqZVcI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pdEAXOvGsIejTqXTC/CootIPpfVARMtLZ0isEZRyu2hslFphN2cQS0IerW0qDfi8tOEXb6mAGVluyJusrosZwjbKFiCwMKP2s8leT4y37mz7SdSZGw/2VO88URVDGtE2Yf4lgqrRk14MRK8PJ5/81tjSyEkmOGqzxce5GLOzV8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J3M5MG4J; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CX0mvH2A; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J3M5MG4J"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CX0mvH2A" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69F9jfZv1955731 for ; Thu, 15 Oct 2026 10:32:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hOqER+APW2quOl6eAUdj+IURL6XVEPDt5bilHrFyOYU=; b=J3M5MG4J+PU7QrQh jIjbJx0CX28k37jKuOCEZp6sRSxzBGkD5QuDTmJHJOXQIP6VaT/Zod1zddtMGlGG FjGMPa1dxSBqw7qSQjrwp3oz9zmDU0VNK0pjt546dg++HvfOWbrNhJIprJYQy0eQ 53atIiLBYoK4Hf35xNIMFjtk3FcRNSj0rpzyKw6kJNpE6t0jQamZPnlyTga0sYVW f12IbSHk1vx3BFZJtWW0TAwaytQE22kIjdA23Zry4Yn/AEe/0JSvWMDDPnRopbGT AmIfJ4M6Ut9FSRJnOmxraD5HqToq4FQIuP0RjWjqExPuyhadAHv1lj1Oqg8ksFf5 XYqMcA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hakdetd5x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Oct 2026 10:32:23 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3a47617a0b3so5044967a91.2 for ; Thu, 15 Oct 2026 03:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792060342; x=1792665142; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=hOqER+APW2quOl6eAUdj+IURL6XVEPDt5bilHrFyOYU=; b=CX0mvH2ATSmAF9CpZdMLhQUiUIKC7ri1+XLmyEFMwZnGCjA6LsGzezubvhOXansAYn idOErjyg7t23gAMB1Hq4T+EuaSKXeFvQe/fKR8cF9Z+IH5WbUZPZYSYnjKZ879N/DtCQ EFanKh3NmXBL5yV0meJYSQSk9hsFnpAkznykIkaG67vWe9AfrCO81Vf4D/f7XaQBJPgm ypP4BPBkJrlm4Lja5esqbQJHRaeLTAVB7Tv84s/bMfwFcmvxGrb+wk3oMKqBQv1gLiHr i61uGXzJnfjNByx/EhKAHm6PZjTWJOFO43atkZUhsepFmnjX2nI2WrcMMp9vsP7Yg018 MHtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792060342; x=1792665142; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=hOqER+APW2quOl6eAUdj+IURL6XVEPDt5bilHrFyOYU=; b=sIKzWKTG8Fiverzp2daJ0SmsL37JrQu815LYjgwBKtELk7K1dOmBTlFBdRFOBlX850 UHMKHtZo/y+PTQhfVQ5vXxZofZKsqCfHcOa9TolIStz4G3s/ZvYOJT2ybTo/vOMhaEiq IdZiFg7y6YdyY0NZ1leBh094JhLA7KX0be+VSavov+qA/P7+baddACnn++7EXuUgZBiD +x18w1G5L4THceuVOl4QOC8l61H6YdoGfQ7pt+yrIYTLjPqcSXF2GkMquWtOx2feOkSE 3EvkZWZ195/D1uKrDDFu96U2qBlz8ZBrPcw61r+eQHi2RL8h+QRHYLnTyQlN3XTnkLtk +KVA== X-Forwarded-Encrypted: i=1; AKwUvBwN+VGjRZscqsS3Iv59H2sz4qP2itCTINkneFnpZPFfqsjg6/eylELjnPs8vwJS0MBbl6SWFejgmcKUH9M=@vger.kernel.org X-Gm-Message-State: AFq9FYK/6uMoap7a3VEZAfuak2LxzWWpBtu3SYT8F771P14oqdeco3zb jHU4hHWL18hCmpLnLAXRjsw7m3NBpHLfAS7b54iDi12I5hqQ2ryIze7UC3xHw2BIpfuWq2rXC93 zFcD3uO0WNoqDZ65cPhkp1vsIdV7cyaefDgK0lHxZgQNw4sE9DLWcAwVDJtWAAtal2Xc= X-Gm-Gg: AYBFou2UZHDV40zE7URx0KmvOfArlYIgeYmZYyQi4Elve31/8AHMLdqrYtyQM8+VCog 3Bnpuy9RKGtNl9CCdDlB/27A7W9Yieqgn29yxO46OyE01h+dv7u70gkmd0FfKc8LwoS3QjBag7r OFhE1PU/o0z2GrfNoF0BktCwg2xB/CRj4UTpNTDPk9ea+mInh2sLAUqNKsk2LDvaACdeuDlUZrd ElvtNbA3o8xZN+YrJ1a0hjgEQMDOIB9XDKismM0NZO5hdv7e/n1h8GzAMSz4zJl4aBMzO4P+kYp RMHPHGKtsPsXKe3OiTy0YStQcb0T3p9ctZbasLVaxZc26mJDubRq0A8UBOlDD12ctMnTeAvSnK5 26nRqUL3jP5PSIPQMSqQBJVRl1SW7C21+dHJRbzqiLQ== X-Received: by 2002:a17:90a:d2c7:b0:3a8:13d6:f740 with SMTP id 98e67ed59e1d1-3ab3a99aa95mr16287921a91.22.1792060342178; Thu, 15 Oct 2026 03:32:22 -0700 (PDT) X-Received: by 2002:a17:90a:d2c7:b0:3a8:13d6:f740 with SMTP id 98e67ed59e1d1-3ab3a99aa95mr16287893a91.22.1792060341482; Thu, 15 Oct 2026 03:32:21 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ac9461d71esm3716055a91.7.2026.10.15.03.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 03:32:21 -0700 (PDT) Date: Thu, 15 Oct 2026 18:32:13 +0800 From: Shawn Guo To: Gourav Kumar Cc: Vishnu Reddy , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] arm64: dts: qcom: nord: Add iris video node Message-ID: References: <20260919-nord-iris-v1-0-94428761ec06@oss.qualcomm.com> <20260919-nord-iris-v1-2-94428761ec06@oss.qualcomm.com> <3b58ccbe-bf6a-4b96-86c5-584d7feeeb6f@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3b58ccbe-bf6a-4b96-86c5-584d7feeeb6f@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=OdENnRTY c=1 sm=1 tr=0 ts=6ad0abb7 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=u3jKQLErjpDJdSScM9wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: 94NwZNrCex3Rn5xukzwil5Eg6NgpYBcN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE1MDA0MSBTYWx0ZWRfX2sWy88ayiKfD qz5SW7VyV7GJ6wPqf0rB2KF/Pu85N0rqx4ypAxLaoYiB3VcdV4CKwSCJYbEhVyPiQ8PWSdzccGI Cdp8OKl578yFcTZkbx3wDr1u025yficSFzUm2kqd5khEeXg+jCRBD0asccGGQkRb4iUcDLt6D+D 8wYOzYKN2RMplh9KQEONM/27PMHlidjQvner8gto+n4R0cvstPFD5FALVBAclggRI8l10xPzBFb 7Nf0rkYnoNA/TqXxjZHQXH5hkT0AHfkNdzPdEFLrikZsvYpvH9ddOjG36hqHDwoo0qq6HwZRDes Ad4SVA5212ynuyBpEPJSCGRc4nFHQPYpKDvfRQeaXlz+YN+WUULs4HPVSouu3dDcbAbGEH8n4cd jh5iXgq+OU8/1fCfDzZX4tWHdYqxfVe+ZDjcyCsD9/mcEeFXFPRBqE/wv+GRrPqOgBj2jUKsBlJ Bib7ie6JFRLcahHCNog== X-Proofpoint-GUID: 94NwZNrCex3Rn5xukzwil5Eg6NgpYBcN X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE1MDA0MSBTYWx0ZWRfX0hzyse8gu0kS vcxnrXhPAB/O3Izw8HOZ7kKfO4CaNcdlwaDSMTRwjBtOZdLVy95XMKfMX55yPQnJfLlEcGuq23A 6Nvcyw4JeHPiuiQFWLHJMK5tsp//jbo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-14_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610150041 On Thu, Oct 15, 2026 at 02:41:26PM +0530, Gourav Kumar wrote: > > > On 9/20/2026 6:46 PM, Shawn Guo wrote: > > On Sat, Sep 19, 2026 at 10:14:56AM +0530, Vishnu Reddy wrote: > >> Add iris video codec to nord SoC, which comes with significantly different > >> powering up sequence than previous platforms, thus different clocks and > >> resets. > >> > >> Signed-off-by: Vishnu Reddy > >> --- > >> arch/arm64/boot/dts/qcom/nord-embedded.dtsi | 114 ++++++++++++++++++++++++++++ > >> 1 file changed, 114 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/nord-embedded.dtsi b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi > >> index 74f4e6be8652..03f827f3e5fc 100644 > >> --- a/arch/arm64/boot/dts/qcom/nord-embedded.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi > >> @@ -1428,6 +1428,120 @@ camcc: clock-controller@9ce0000 { > >> #power-domain-cells = <1>; > >> }; > >> > >> + iris: video-codec@aa00000 { > >> + compatible = "qcom,nord-iris", "qcom,glymur-iris"; > >> + reg = <0x0 0x0aa00000 0x0 0xf0000>; > > > > nord-embedded.dtsi is a place to accommodate Nord Embedded variant > > specific resource descriptions, like clock, regulator, pinctrl, > > interconnect, power domain, PHY, etc. The rest of descriptions should > > go to nord.dtsi, like reg, interrupts, iommu, dma, etc. > > > > Iris depends on providers such as videocc, nwgcc, hscnoc, and mc_virt, > which are defined only in nord-embedded.dtsi. > Moving the Iris node into nord.dtsi would leave unresolved references in > DTS variants that don’t include the embedded file, causing DTB build > failures. > We should keep the iris node in nord-embedded.dtsi. Could you read my comment one more time? I was asking to split the Iris node, move descriptions like reg, interrupts, iommu, dma, etc to nord.dtsi, and keep clocks, resets, interconnects, power domains, etc in nord-embedded.dtsi. Take a look at the existing device nodes as examples, that's already what we are doing. Shawn