From: Peng Fan <peng.fan@oss.nxp.com>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: Frank Li <Frank.Li@nxp.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
pierluigi.p@variscite.com,
Stefano Radaelli <stefano.r@variscite.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v1 1/1] arm64: dts: imx8mn-evk: Pass GPIO_OPEN_DRAIN flag on i2c3 GPIOs
Date: Thu, 15 Oct 2026 19:02:48 +0800 [thread overview]
Message-ID: <atCy2Li2wrPHhW8K@shlinux89> (raw)
In-Reply-To: <20261015081149.5919-1-stefano.r@variscite.com>
On Thu, Oct 15, 2026 at 10:11:49AM +0200, Stefano Radaelli wrote:
>From: Stefano Radaelli <stefano.r@variscite.com>
>
>scl-gpios and sda-gpios need GPIO_OPEN_DRAIN flag, otherwise the
>following run-time warning is seen:
>
>gpio-146 (scl): enforced open drain please flag it properly in DT/ACPI DSDT/board file
>
>Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
>---
> arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
>index 3e590afa4fab..036afa0f6990 100644
>--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
>+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
>@@ -287,8 +287,8 @@ &i2c3 {
> pinctrl-names = "default", "gpio";
> pinctrl-0 = <&pinctrl_i2c3>;
> pinctrl-1 = <&pinctrl_i2c3_gpio>;
>- scl-gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>;
>- sda-gpios = <&gpio5 19 GPIO_ACTIVE_HIGH>;
>+ scl-gpios = <&gpio5 18 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>+ sda-gpios = <&gpio5 19 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
I think ODE should be configured for pinctrl_i2c3_gpio.
Regards
Peng
> status = "okay";
>
> pca6416: gpio@20 {
>--
>2.47.3
>
next prev parent reply other threads:[~2026-10-15 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 8:11 Stefano Radaelli
2026-10-15 11:02 ` Peng Fan [this message]
2026-10-15 11:12 ` Stefano Radaelli
2026-10-15 13:32 ` Peng Fan
2026-10-15 13:33 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atCy2Li2wrPHhW8K@shlinux89 \
--to=peng.fan@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierluigi.p@variscite.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=stefano.r@variscite.com \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®