mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefano Garzarella <sgarzare@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>
Cc: mst@redhat.com, linux-kernel@vger.kernel.org,
	 Laurent Vivier <lvivier@redhat.com>,
	virtualization@lists.linux.dev,
	 Jason Wang <jasowangio@gmail.com>
Subject: Re: [PATCH] MAINTAINERS: add missing virtio/vdpa/vduse/vhost headers
Date: Thu, 15 Oct 2026 15:30:21 +0200	[thread overview]
Message-ID: <atDSrbtSsWL_3JDp@sgarzare-redhat> (raw)
In-Reply-To: <20261015094049.107999-1-eperezma@redhat.com>

On Thu, Oct 15, 2026 at 11:40:49AM +0200, Eugenio Pérez wrote:
>Several headers related to virtio, vDPA, VDUSE and vhost were not
>covered by any specific MAINTAINERS entry and fell through to the
>catch-all THE REST section:
>
>- include/linux/device-id/virtio.h: not matched by the existing
>  "include/linux/virtio*.h" glob, which only matches files directly
>  under include/linux/ and does not recurse into subdirectories.
>
>- include/uapi/linux/vdpa.h: the in-kernel include/linux/vdpa.h was
>  listed under VIRTIO CORE but its UAPI companion was missing; the
>  "include/uapi/linux/virtio_*.h" pattern does not match it because
>  the filename lacks the "virtio_" prefix.
>

Maybe we should tell to the agent to avoid useless info in the commit 
message, I mean it's pretty clear that "include/uapi/linux/virtio_*.h" 
will not match include/uapi/linux/vdpa.h ...

>- include/uapi/linux/vduse.h: there is no dedicated VDUSE section in
>  MAINTAINERS; the driver lives under drivers/vdpa/ which is already
>  covered by VIRTIO CORE, so the UAPI header belongs there too.
>
>- include/uapi/linux/vhost_types.h: the VIRTIO HOST (VHOST) section
>  explicitly lists include/uapi/linux/vhost.h but omits its companion
>  types header.
>
>Assisted-by: claude-sonnet 4.6

nit: the suggested tag in Documentation/process/coding-assistants.rst is
Assisted-by: LLM [TOOL1] [TOOL2]

>Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
>---
> MAINTAINERS | 4 ++++
> 1 file changed, 4 insertions(+)

Anyway, the patch LGTM:

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>


Maybe to be fixed in another patch, LLM here found also others files 
related to virtio/vhost/vdpa uncovered:

Other virtio-related files not covered by any virtio/vhost/vdpa
MAINTAINERS entry:

- Documentation/ABI/testing/sysfs-fs-virtiofs
   Current:   no section (THE REST only)
   Suggested: VIRTIO FILE SYSTEM

- Documentation/userspace-api/vduse.rst
   Current:   DOCUMENTATION only
   Suggested: VIRTIO CORE (already lists sysfs-class-vduse)

- include/trace/events/vsock_virtio_transport_common.h
   Current:   TRACING only
   Suggested: VIRTIO AND VHOST VSOCK DRIVER
              (next to virtio_transport_common.c)

- drivers/nvdimm/virtio_pmem.h
   Current:   LIBNVDIMM only
   Suggested: VIRTIO PMEM DRIVER (lists virtio_pmem.c and
              nd_virtio.c, but not the header)

- Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
   Current:   GPIO + DT bindings
   Suggested: VIRTIO GPIO DRIVER

- Documentation/devicetree/bindings/i2c/i2c-virtio.yaml
   Current:   I2C + DT bindings
   Suggested: VIRTIO I2C DRIVER

- Documentation/networking/device_drivers/ethernet/amd/pds_vdpa.rst
   Current:   NETWORKING + DOCUMENTATION
   Suggested: PDS DSC VIRTIO DATA PATH ACCELERATOR
              (only lists drivers/vdpa/pds/)

- include/linux/mlx5/mlx5_ifc_vdpa.h
   Current:   MLX5 core/IB only
   Suggested: possibly MELLANOX MLX5 VDPA DRIVER (debatable, it's an
              mlx5 interface header)


I'll send a fix for the vsock events.

Thanks,
Stefano


      parent reply	other threads:[~2026-10-15 13:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15  9:40 Eugenio Pérez
2026-10-15  9:44 ` Eugenio Perez Martin
2026-10-15 13:30 ` Stefano Garzarella [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atDSrbtSsWL_3JDp@sgarzare-redhat \
    --to=sgarzare@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=jasowangio@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®