From: Suhaas Joshi <suhaas@s-joshi.in>
To: SJ Park <sj@kernel.org>
Cc: akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
aethernet65535@gmail.com
Subject: Re: [PATCH v4 0/2] mm/damon/core: Iterate over installed probes instead of DAMON_MAX_PROBES
Date: Thu, 15 Oct 2026 20:45:48 +0530 [thread overview]
Message-ID: <atDtNpEiy96Lbna7@fedora> (raw)
In-Reply-To: <20261015142933.105760-1-sj@kernel.org>
On Thu, Oct 15, 2026 at 07:29:32AM -0700, SJ Park wrote:
> On Thu, 15 Oct 2026 19:25:23 +0530 Suhaas Joshi <suhaas@s-joshi.in> wrote:
>
> > Hello,
> >
> > This is v4 of a series I sent earlier. Please find changelog below.
> >
> > There were two "todo: " items of the same nature in mm/damon/core.c. Both
> > of these suggested that we should iterate over only installed probes while
> > updating (last_)probe_hits[] during merging/splitting regions, instead of
> > iterating over the entire array, which may have empty/unused indices.
> >
> > So this patch series does exactly that. It replaces the for-loop over
> > [0, DAMON_MAX_PROBES) with a damon_for_each_probe() over the probe list of
> > the context.
>
> Looks good to me, thank you.
>
> I applied this series to damon/next [1] tree. We are now quite close to next
> merge window. It may better to focus on making mm.git more stabilized and
> therefore ready for the next merge window, rather than adding more changes that
> are not really urgent. I understand this series is not really urgent. Hence,
> Andrew might not add this patch until next -rc1 release. In the case, I will
> request adding this to mm.git after next -rc1 release. So, no action from your
> side is needed for now. Let me know if you think this is really urgent.
No, its not urgent at all. We can wait until after -rc1 indeed.
Thanks a lot to you and Liew for the reviews! :)
Regards
Suhaas
>
> [1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
>
>
> Thanks,
> SJ
>
> [...]
prev parent reply other threads:[~2026-10-15 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 13:55 Suhaas Joshi
2026-10-15 13:57 ` [PATCH v4 1/2] mm/damon/core: Use only installed probe in damon_merge_two_regions() Suhaas Joshi
2026-10-15 14:21 ` SJ Park
2026-10-15 13:57 ` [PATCH v4 2/2] mm/damon/core: Copy only installed probe in damon_split_region_at() Suhaas Joshi
2026-10-15 14:25 ` SJ Park
2026-10-15 14:29 ` [PATCH v4 0/2] mm/damon/core: Iterate over installed probes instead of DAMON_MAX_PROBES SJ Park
2026-10-15 15:15 ` Suhaas Joshi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atDtNpEiy96Lbna7@fedora \
--to=suhaas@s-joshi.in \
--cc=aethernet65535@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®