mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: jean-baptiste.maneyrol@tdk.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Jonathan Cameron" <jonathan.cameron@oss.qualcomm.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] iio: imu: inv_icm42600: fix parsing of all FIFO frames for odr change
Date: Fri, 16 Oct 2026 13:19:45 +0300	[thread overview]
Message-ID: <atH6QdvvmEPzkGE2@ashevche-desk.local> (raw)
In-Reply-To: <20261016-iio-imu-inv-icm42600-fix-odr-change-event-in-all-frames-v1-1-b2bb168a0551@tdk.com>

On Fri, Oct 16, 2026 at 11:28:10AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:

> For getting all odr change events, we need to parse all FIFO frames
> in each iio device. Fix this correctly by sending effectively all
> frames to all iio devices.
> 
> Previously only batches of frames containing a matching sensor event
> were sent to the corresponding iio device.

...

> -		ret = inv_icm42600_gyro_parse_fifo(st->indio_gyro);
> -		if (ret)
> -			return ret;
>  	}

+ Blank line.

> +	ret = inv_icm42600_gyro_parse_fifo(st->indio_gyro);
> +	if (ret)
> +		return ret;
>  
>  	/* handle accelerometer timestamp and FIFO data parsing */
>  	if (st->fifo.nb.accel > 0) {
>  		ts = &accel_st->ts;
>  		inv_sensors_timestamp_interrupt(ts, st->fifo.watermark.eff_accel,
>  						st->timestamp.accel);
> -		ret = inv_icm42600_accel_parse_fifo(st->indio_accel);
> -		if (ret)
> -			return ret;
>  	}

+ blank line.

> +	ret = inv_icm42600_accel_parse_fifo(st->indio_accel);
> +	if (ret)
> +		return ret;
>  
>  	return 0;
>  }

	return inv_icm42600_accel_parse_fifo(st->indio_accel);

?

...

Similar comments to the inv_icm42600_buffer_hwfifo_flush() changes.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-10-16 10:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16  9:28 Jean-Baptiste Maneyrol via B4 Relay
2026-10-16 10:19 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atH6QdvvmEPzkGE2@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jean-baptiste.maneyrol@tdk.com \
    --cc=jic23@kernel.org \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®