From: Lukas Wunner <lukas@wunner.de>
To: vasilij.kernel@tototo.si
Cc: Aun-Ali Zaidi <admin@kodeit.net>,
Aditya Garg <aditya.garg@linux.dev>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Kerem Karabay <kekrby@gmail.com>,
Atharva Tiwari <evepolonium@gmail.com>,
Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
Subject: Re: [PATCH v3] drm/appletbdrm: Add suspend and resume support
Date: Fri, 16 Oct 2026 10:05:40 +0200 [thread overview]
Message-ID: <atHa1KHess5QUpXW@wunner.de> (raw)
In-Reply-To: <20261015-appletbdrm-pm-v3-1-47377176619a@tototo.si>
On Thu, Oct 15, 2026 at 11:47:36PM +0200, Vasilij Markin via B4 Relay wrote:
> The driver has no USB power management callbacks, so the USB core
> unbinds it before system suspend and binds it again on resume. The DRM
> device is unregistered and registered again on every suspend and resume
> cycle, userspace driving the Touch Bar through it (such as tiny-dfr)
> loses its device, and the Touch Bar stays dark after resume.
>
> Implement suspend and resume with drm_mode_config_helper_suspend() and
> drm_mode_config_helper_resume(), so the device stays registered and the
> last committed state is restored on resume. If the device was reset
> while suspended, repeat the probe-time handshake first.
>
> Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Vasilij Markin <vasilij.kernel@tototo.si>
Applied to drm-misc-next, thanks. Note that we're at the tail end
of the cyce and the drm subsystem has an rc6 cut-off. So this is
v7.5 material.
The Fixes tag could be argued against because this isn't really a fix,
it's more like a missing feature. But I can see how this is useful for
people on older LTS kernels, so I let it slide.
Thanks,
Lukas
prev parent reply other threads:[~2026-10-16 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 21:47 Vasilij Markin via B4 Relay
2026-10-16 8:05 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atHa1KHess5QUpXW@wunner.de \
--to=lukas@wunner.de \
--cc=aditya.garg@linux.dev \
--cc=admin@kodeit.net \
--cc=airlied@gmail.com \
--cc=atharvatiwarilinuxdev@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=evepolonium@gmail.com \
--cc=kekrby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=vasilij.kernel@tototo.si \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®