From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f193.google.com (mail-dy1-f193.google.com [74.125.82.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F92B49B44E for ; Mon, 19 Oct 2026 08:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792399604; cv=none; b=FsE7fM64klvv3DX4Oy6DtSbecMil684aM+PKUsaiMoz68mZvM7C3NI7nn8OdSTGIZp8AZNm2p7Biv4vuWzoz8Who+k/4MOfHvelKMhAw+kkFP7c1epjIHbzuSp0oBdxfUtc2ORtLiES7orC/aUO+pG0E1rIRuTUBndP6z5cIqAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792399604; c=relaxed/simple; bh=eHZnAQ4WZ6l0Eaf7O6GrKOei6GuPLKILghtVjSoOUZ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d8WyphfAsYcnIJNG9rOQr6sPzmw9vsAz1iZypCh+teOfyLPgiWR2Ar5+tCYLxaK0fy8ZnCVr2PhzTvZNgvtri+lnHABFqWX1kfqK77Z8f+TAqmjbPA+on/YR99TDTWi4GDeuY+FZzFvdr1yUmj3/n2RRb2MGb08dvQoYoFvgXu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TGCBEKQk; arc=none smtp.client-ip=74.125.82.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TGCBEKQk" Received: by mail-dy1-f193.google.com with SMTP id 5a478bee46e88-35829219da8so3345397eec.0 for ; Mon, 19 Oct 2026 01:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792399602; x=1793004402; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=R81uGUDBlkE6/NsZn54/pArgBx2k2sR0sHNuKkRuNRE=; b=TGCBEKQkm9ByF8rvnvFnmryNDAtYJzZVjaHD7See3f37qJQ6bm4SthcPi7aoNyn3mn UQJhGGtiAgQkekfzYzM5ELHrgZZCcMwoAG/3Ck2xWlmvDxD4IMuD3UT9x0OcCmssenT3 9XisLTYxJJYKEQyVtRnR6zRu/SxKw7ptJEHm/Hg+RwdMHiQifoorTHwT61RelEVzy17l Uq0NHQTNkJxmBJyRBHqvMJBP8zJiAJs82liG6cEBH3VE9KG9ebkzHzeBYYwhIODuVbkP WJk7ASSpPwYb7OZQZazYWwoCmHHg2jiZ4GSYP8nAmRit5c1MzhVQzwynfRU+jPBeNYgu 9FqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792399602; x=1793004402; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=R81uGUDBlkE6/NsZn54/pArgBx2k2sR0sHNuKkRuNRE=; b=PPElEvCf7iQc2zJ7pAuyuaqa5EgLdxJrv+K2E85wdQG1eQotmiM3bdnJ9NmXGLHyaW mab2d+TyKCSMGKhSUL32YrP1bN89RbTB+4qRLuQR/z/9eQyNG5OSpW2lGLNoZb467/Ly Cv2iqynVC0vokh2gFMKSY2cPq4w+MA4feHE5YoJ3d8ubVyaRTrVMjt34D10AQiEsdEwl CVmUbT91N7+46L86N27Hh5UnNZxF7mV0iSXLcnDdkhZ+1tjdoG6NH433nnQ6tgqY+G5I K8MJbNrJSawf+rpL5MaB8UjdCZDpA75lIQbyTNtIZar6/lysoo9Qb2yg85jqyIwemJsx waNg== X-Forwarded-Encrypted: i=1; AKwUvBw2W5ZwkvfoaP3m1BepopQ1eFr2pGSQEVHyc9WHxq5PHrX1T1nh/raCj0h91v0VLZdctfIV3E1NCWCky6Q=@vger.kernel.org X-Gm-Message-State: AFq9FYJ4T2MwV1XxKVWNbezecYZkdoQFJxuG0/bLW45EcfNIMlCa/xf9 F8dKmZczwQPFi68a/wW/mdLnO/mDkafBQpLMkSfwHH4SpspQVyF5fCHT X-Gm-Gg: AYBFou2F344Fnmv3/2lPd0GZmJIeZPYoXPKvX5at4jrQimSDxUVQ42VClV1s4V/RTx7 rWL9R5xgnfyQ1Z6drhQLZoGGwfQIszYMf8APli/a8wCcniGHpmCQ1iScllfvaMKM7/++Srd3E77 QQB6/+vbQHrj5wPeEDHWIMQ3UrQRq2INDq5dndGi11yMcS5KHYHlnWsENa6PEx4KsB2U2oVp5/0 R+b+TqFv/WU3b7AoH2m5G7Fo+wUOMQH70hoZGd+zObnl6kU3Z3G3IwPcuu4Vngl+TfEdJ8UJX3X z3S4x3pjRrGN9Xq6VSsd3z3vjgDk2W8VHssO8K2DbWadgRLWIcHmhwsBGyOm3rmHYFsBcI7nU3w fPIilFj7sCcGqbOLsNxs+781GgOei+ibzZNu3MfbvS0Ck04qyc6QxaM/LTHp6eu4s5iQrYJyLY7 OSHoDVnLHKqVs2LJWtbCgzQXoe0Zy49jkHqZf0R27iWYmtbbvevCA64g5kxwRKAFo6lAa5EAvDQ FX4AbKPa7N6XlwphhmYCg== X-Received: by 2002:a05:701b:2092:20b0:143:808b:b178 with SMTP id a92af1059eb24-1825c27d1a0mr14024480c88.26.1792399602431; Mon, 19 Oct 2026 01:46:42 -0700 (PDT) Received: from blue (104.194.64.109.16clouds.com. [104.194.64.109]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-360826875b3sm32116751eec.21.2026.10.19.01.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2026 01:46:41 -0700 (PDT) Date: Mon, 19 Oct 2026 16:46:37 +0800 From: yyaqia@gmail.com To: Thomas Zimmermann , deller@gmx.de, simona@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, yaoyiqi3@huawei.com, stable@vger.kernel.org Subject: Re: [PATCH v3 2/3] fbcon: Rebuild rotated font buffer on font change Message-ID: References: <20261016073023.490430-1-yyaqia@gmail.com> <20261016073023.490430-3-yyaqia@gmail.com> <3382a02c-ed79-4214-99c5-dc81ee59d633@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3382a02c-ed79-4214-99c5-dc81ee59d633@suse.de> On 2026-10-16 09:59, Thomas Zimmermann wrote: > > It's way too long and boring to read. Can you please try to shorten the > AI-generated commit description? > > Sorry for that, I was a bit lazy to think commit desc by myself. I am new to kernel and a little afraid that my message does not cover all things. > > - Also select the blitting type again in the error path of > > fbcon_do_set_font(). On tile-blitting hardware, set_blitting_type() > > uploads the font map to the text engine; without the second call, a > > failed vc_resize() left the engine with the rejected font (found by > > the Sashiko review). > > The problem is that rotate_font can fail as well. Handling that in the error > path is not possible; hence results might be worse than keeping the rejected > font.  Can you try to keep the original rotated font and reinstall that > directly? > Good advice, I will fix this in V4. Thanks for your review, Yao Yiqi