From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender5-op-o11.zoho.com (sender5-op-o11.zoho.com [165.173.182.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60D1A4CF489 for ; Sat, 17 Oct 2026 20:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.182.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792267752; cv=pass; b=Spm88tQqzKH68XJGL5sN+woYvim3vsWSxM0ysDTpQZw8R2fvnVfcxuhEkgwcMuQFxdzuyfjLKKf37djZeE8XptJvhlUoonVM0WmMF+werEUumBbpCwlTWeL2Cp4dMPop6MXV3/PReiHfaMBu6a9N7xTxpc3xGY19jzq/f8ajMOc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792267752; c=relaxed/simple; bh=xIyIC8AOaowHOJTyLtB5oWPtdmEniOxx2vyJJk0BwME=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DPW/oSghB882s9tiSJM5RupYbQmgJV8ElUnw+8ex6AjMjO9c4rjBCQSwfp/rBFJgm+s6TNfVqn9T1YoxMGDTBIox9P4MliSemZATWkT4g8/9yJW09Pyrhc/Wxk9DdZN/pxPI7NDAGo1pAoSE5XPGWNT6nz7+qxyXIxpu3uq/e68= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=sebastian.reichel@collabora.com header.b=Mhwx1CWO; arc=pass smtp.client-ip=165.173.182.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=sebastian.reichel@collabora.com header.b="Mhwx1CWO" ARC-Seal: i=1; a=rsa-sha256; t=1792267737; cv=none; d=zohomail.com; s=zohoarc; b=MV1Ihi5w65tETzvdAVruY+4iDWVUcyf52bMDv/scjrc/4U2y3Tce6fU2XQuDcLINvooMKGRU/IME7U+KasheiJr6740jM6AbN4U7n6RCq8Thmplz53qE+aV54eg0/R6Dp7NEc9j0uhXP8cktPl+EHM3kHIz2F7ZQ9IbVcLdQnzY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792267737; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=dMd2Cnyzg2AY+6hcrzhQpnTa668bEMUasMPE/0oO2OQ=; b=hHpwexE19pNHq5SQ0sbWpxgS8fW7BgUWEvy3n1rLI2JMpT1pP5gi68y1sQyxzxwakZqdL1qO1kXqIC5CUE/MXfQsh8Ul7lPQmk3JiCimynDgvS7Eoxvgh8ko2N9ox6gXEMuaMtfRf2va5IyuwQySJViJOnE9et6okIEmdFjA788= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=sebastian.reichel@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1792267737; s=zohomail; d=collabora.com; i=sebastian.reichel@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=dMd2Cnyzg2AY+6hcrzhQpnTa668bEMUasMPE/0oO2OQ=; b=Mhwx1CWODXntMcsfwl/pzf4hjgInJ9YkSHHMb4+jv481dlldfxfT3DxApm0ls5Pk 8PVbfAXwuoe7AzD7O38DBAePwaac2lZ+goXvDLQ3DhGBE64z+SV91gM7IksOtBhyx69 3ey2F7WXGAucl9kibvmidAgHJsnqsbtnRzp3MZho= Received: by smtp.zohomail.com with SMTPS id 1792267734140505.60928145954665; Sat, 17 Oct 2026 13:08:54 -0700 (PDT) Received: by venus (Postfix, from userid 1000) id 8ECDA182304; Sat, 17 Oct 2026 22:08:48 +0200 (CEST) Date: Sat, 17 Oct 2026 22:08:48 +0200 From: Sebastian Reichel To: Shawn Lin Cc: Neil Armstrong , Vinod Koul , linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, Heiko Stuebner , linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: rockchip: snps-pcie3: Raise the SRAM init timeout Message-ID: References: <1792047775-77954-1-git-send-email-shawn.lin@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eirj7uqn7dp5um72" Content-Disposition: inline In-Reply-To: <1792047775-77954-1-git-send-email-shawn.lin@rock-chips.com> X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.13.1.5.4/292.264.81 X-ZohoMailClient: External --eirj7uqn7dp5um72 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] phy: rockchip: snps-pcie3: Raise the SRAM init timeout MIME-Version: 1.0 Hi, On Thu, Oct 15, 2026 at 03:02:55PM +0800, Shawn Lin wrote: > The SRAM initialization of the PCIe3 PHY may take longer than the 500us > currently allowed, especially on a slow power-up such as at low > temperature. In that case the driver reports >=20 > lock failed 0x..., check input refclk and power supply >=20 > even though the input refclk and power supply are fine. >=20 > Raise the timeout to 20ms and use a named constant for it, applied to > both the RK3568 and RK3588 paths. >=20 > Signed-off-by: Shawn Lin > --- >=20 > drivers/phy/rockchip/phy-rockchip-snps-pcie3.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c b/drivers/phy= /rockchip/phy-rockchip-snps-pcie3.c > index 4e8ffd1..bbbfd6d 100644 > --- a/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c > +++ b/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c > @@ -19,6 +19,8 @@ > #include > #include > =20 > +#define RK_PCIE_SRAM_INIT_TIMEOUT 20000 #define RK_PCIE_SRAM_INIT_TIMEOUT_US 20 * USEC_PER_MSEC Otherwise Reviewed-by: Sebastian Reichel Greetings, -- Sebastian > + > /* Register for RK3568 */ > #define GRF_PCIE30PHY_CON1 0x4 > #define GRF_PCIE30PHY_CON6 0x18 > @@ -127,7 +129,7 @@ static int rockchip_p3phy_rk3568_init(struct rockchip= _p3phy_priv *priv) > ret =3D regmap_read_poll_timeout(priv->phy_grf, > GRF_PCIE30PHY_STATUS0, > reg, SRAM_INIT_DONE(reg), > - 0, 500); > + 0, RK_PCIE_SRAM_INIT_TIMEOUT); > if (ret) > dev_err(&priv->phy->dev, "%s: lock failed 0x%x, check input refclk and= power supply\n", > __func__, reg); > @@ -187,11 +189,11 @@ static int rockchip_p3phy_rk3588_init(struct rockch= ip_p3phy_priv *priv) > ret =3D regmap_read_poll_timeout(priv->phy_grf, > RK3588_PCIE3PHY_GRF_PHY0_STATUS1, > reg, RK3588_SRAM_INIT_DONE(reg), > - 0, 500); > + 0, RK_PCIE_SRAM_INIT_TIMEOUT); > ret |=3D regmap_read_poll_timeout(priv->phy_grf, > RK3588_PCIE3PHY_GRF_PHY1_STATUS1, > reg, RK3588_SRAM_INIT_DONE(reg), > - 0, 500); > + 0, RK_PCIE_SRAM_INIT_TIMEOUT); > if (ret) > dev_err(&priv->phy->dev, "lock failed 0x%x, check input refclk and pow= er supply\n", > reg); > --=20 > 2.7.4 >=20 >=20 --eirj7uqn7dp5um72 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmrT1dAACgkQ2O7X88g7 +pqxcg//Vo/x9r1Rt9Y4F7K6g++zkELgZxMOI/hGgSejnF10Ctfi7/7c2RT+PJZG qj91qrr6ATEiwzSAJh85eKGxD2SzmT/3yNxo2QyjQtCgBaz4+7dwcvRgI4KZ4sRJ WSgrzLiyTmJD4U1I0akKsKAOkIKEv8+UlNWBZKK3XKw4EFQ38gBWvPpY5NzUtdSQ WrmGL0wHPLlyT6kzAVDop5HUJ+lqFSY+qD8PGWH1K4/q0fbGXu3WjiDd8z25ol8+ F8PJPgnBOGTI58xVR1dzfUij8FVFSmNsN+cfRtcFRxXeZ19m1N/Mk2rvPyUsyl1R c+l4ICzUrgv3A97NoTdRISaJuMN4fwd2kwJWnwVM6vsR6T/17a6MZQmVdiYK80C2 PmzCI8dVmQg6wEr1fZs2PPWb6HVUjZq+fqnXYLvByv31NsYgRTq6Nyw3wpF7e5Lo zNwDCGjROmSdFlgoJcMNH6IBTxiUSebxn2Ko3rXthyD6LgbptvdKlhzebxOxnMbE n8PQxMZFnzVJBhucQsUcTT3SaafWjXJJQUTXXIM5LVsmgkTVWAKV+XBxKbe2qEje tudRq9OHO1JtQ0uP7Nw16CHmgNAxqM5XpTFkstHhOqtujiqwRYfsSSFAZHULOJ3S jBkGYvg0ogV/rDNAqneztxXkqRywwcDViwC4cZWi4oe2DQ6qcWQ= =rkYy -----END PGP SIGNATURE----- --eirj7uqn7dp5um72--