Re: [PATCH] ASoC: codecs: wsa884x: Add mute control knob

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On Sat, Oct 17, 2026 at 09:45:33PM +0200, Sebastian Reichel wrote:
> On Thu, Oct 15, 2026 at 07:10:58PM +0100, Mark Brown wrote:

> > > +	guard(mutex)(&wsa884x->sp_lock);
> > > +	wsa884x->trigger_mute = mute;
> > > +	wsa884x_set_mute(component, mute || wsa884x->user_mute);

> > ...I can't see what guarantees that pa_on is set here.  It looks like
> > these are mono speakers with multiple speakers connected to a stream,
> > someone could fiddle with the routing on an active stream and power up a
> > speaker.  We should probably recheck in the speaker event.

> pa_on is set via SND_SOC_DAPM_POST_PMU/SND_SOC_DAPM_PRE_PMD. My
> rationale was, that mute update is not needed with the widget
> powered down and at startup the .mute_stream handler will update
> the mute state automatically.

Right, it'll work most of the time but if someone changes the routing
while the stream is running you should be able to hit a problem.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]