From: Dan Carpenter <error27@gmail.com>
To: Melih Emik <melihemik@noirlang.tr>
Cc: parthiban.veerasooran@microchip.com,
christian.gromm@microchip.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: dim2: remove redundant dev_err() calls
Date: Sun, 18 Oct 2026 14:06:17 +0300 [thread overview]
Message-ID: <atSoKUqHquEhdTXa@stanley.mountain> (raw)
In-Reply-To: <179232125059.295089.11354359693726377618@noirlang.tr>
On Sun, Oct 18, 2026 at 02:00:50PM +0300, Melih Emik wrote:
> On Sun, Oct 18, 2026 at 01:45:27PM +0300, Dan Carpenter wrote:
> > Don't put this kind of meta commentary in the commit message. It's
> > expected that people test their patches, so there is no need to say
> > it. If there is something unexpected then put it below the ---
> > cut off line
>
> Hi Dan,
>
> Thank you very much for the helpful guidance and explanation! That makes
> complete sense, and I really appreciate you taking the time to point it out.
>
> I have updated the patch to drop the meta commentary from the commit message
> and placed the test notes below the "---" cut-off line in v2.
>
> Thanks again for your review and time!
Please don't send AI emails... It's so depressing and cliche to hear,
"Yes, you are right!" from an AI.
regards,
dan carpenter
prev parent reply other threads:[~2026-10-18 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 10:42 Melih Emik
2026-10-18 10:45 ` Dan Carpenter
2026-10-18 11:00 ` Melih Emik
2026-10-18 11:06 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atSoKUqHquEhdTXa@stanley.mountain \
--to=error27@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=melihemik@noirlang.tr \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®