From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Qiliang Yuan <odys.yuan@gmail.com>
Cc: Kees Cook <kees@kernel.org>, Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Collingbourne <peter@pcc.me.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
kasan-dev@googlegroups.com
Subject: Re: [PATCH v2] string: copy byte by byte in sized_strscpy() under KASAN
Date: Mon, 19 Oct 2026 14:25:17 +0300 [thread overview]
Message-ID: <atX-HWSd9WdZ8Qr4@ashevche-desk.local> (raw)
In-Reply-To: <atX9yfR7XwaIo457@ashevche-desk.local>
On Mon, Oct 19, 2026 at 02:23:58PM +0300, Andy Shevchenko wrote:
> On Mon, Oct 19, 2026 at 09:59:01AM +0800, Qiliang Yuan wrote:
...
> > - if (IS_ENABLED(CONFIG_KMSAN))
> > + if (IS_ENABLED(CONFIG_KMSAN) || IS_ENABLED(CONFIG_KASAN_GENERIC) ||
> > + IS_ENABLED(CONFIG_KASAN_SW_TAGS))
> > max = 0;
>
> Logically better to have them grouped by SANitizer:
>
> if (IS_ENABLED(CONFIG_KASAN_GENERIC) || IS_ENABLED(CONFIG_KASAN_SW_TAGS) ||
> IS_ENABLED(CONFIG_KMSAN))
Or other way around (I think it will be shorter)
if (IS_ENABLED(CONFIG_KMSAN) ||
IS_ENABLED(CONFIG_KASAN_GENERIC) || IS_ENABLED(CONFIG_KASAN_SW_TAGS))
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-10-19 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 1:59 Qiliang Yuan
2026-10-19 11:23 ` Andy Shevchenko
2026-10-19 11:25 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atX-HWSd9WdZ8Qr4@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=andy@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=odys.yuan@gmail.com \
--cc=peter@pcc.me.uk \
--cc=ryabinin.a.a@gmail.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®