From: Petr Mladek <pmladek@suse.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kees Cook <kees@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Tycho Andersen <tycho@tycho.pizza>
Subject: Re: [PATCH v4 1/2] vsprintf: Don't leak pointers for %ps without KALLSYMS enabled
Date: Mon, 19 Oct 2026 17:18:32 +0200 [thread overview]
Message-ID: <atY0yIjwX1zogzsP@pathway.suse.cz> (raw)
In-Reply-To: <20261019-vsprintf_kallsym-v4-1-ffd3c012d00c@linutronix.de>
On Mon 2026-10-19 12:21:50, Sebastian Andrzej Siewior wrote:
> The "%ps" format modifier prints the name of the symbol which is more
> valuable in terms of debugging and does not leak the actual pointer.
>
> Without KALLSYMS it will leak the pointer which is not intended. The
> default policy for pointers is to print a hashed value and not to leak
> the actual pointer.
>
> Print a hashed pointer for any symbol resolution witout KALLSYMS
> enabled like it is the case for %p.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Looks good to me:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2026-10-19 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 10:21 [PATCH v4 0/2] vsprintf: Don't leak pointers Sebastian Andrzej Siewior
2026-10-19 10:21 ` [PATCH v4 1/2] vsprintf: Don't leak pointers for %ps without KALLSYMS enabled Sebastian Andrzej Siewior
2026-10-19 15:18 ` Petr Mladek [this message]
2026-10-19 10:21 ` [PATCH v4 2/2] kallsyms: Don't leak pointers for unresolved symbols Sebastian Andrzej Siewior
2026-10-19 10:34 ` Andy Shevchenko
2026-10-19 10:50 ` Sebastian Andrzej Siewior
2026-10-19 11:05 ` Andy Shevchenko
2026-10-19 12:14 ` Sebastian Andrzej Siewior
2026-10-19 15:34 ` Petr Mladek
2026-10-19 15:40 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atY0yIjwX1zogzsP@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tycho@tycho.pizza \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®