From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Seongjae Jeong <jsjlee1020@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix submit accounting for IPU writeback
Date: Mon, 19 Oct 2026 15:31:54 +0000 [thread overview]
Message-ID: <atY36oouQpmVHtwJ@google.com> (raw)
In-Reply-To: <d1236f9a-b5ec-434d-9293-54cf9f6364ef@kernel.org>
On 10/19, Chao Yu via Linux-f2fs-devel wrote:
> On 10/14/26 19:26, Seongjae Jeong wrote:
> > f2fs_write_cache_pages() uses the submitted count, which is set to
> > fio.submitted in f2fs_write_single_data_page(), to update nwritten
> > and decrement wbc->nr_to_write.
> >
> > In the OPU path, f2fs_submit_page_write() sets fio->submitted to 1.
> > However, in the IPU path, fio->submitted is never set and remains zero.
> > As a result, successful IPU writes are not accounted for.
> > This can cause asynchronous writeback to continue beyond its budget.
> >
> > Set fio->submitted in f2fs_inplace_write_data() after a page is
> > successfully merged into a bio or submitted, so that successful
> > IPU writes are included in the writeback accounting.
> >
>
> Missing Fixes and Cc stable line?
Cc: stable@kernel.org
Fixes: d68f735b3bc9 ("f2fs: check io submission more precisely")
>
> > Signed-off-by: Seongjae Jeong <jsjlee1020@gmail.com>
> Reviewed-by: Chao Yu <chao@kernel.org>
>
> Thanks,
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-10-19 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 11:26 Seongjae Jeong
2026-10-19 11:09 ` Chao Yu
2026-10-19 15:31 ` Jaegeuk Kim [this message]
2026-10-19 15:40 ` [f2fs-dev] " patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atY36oouQpmVHtwJ@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=jsjlee1020@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®