From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA5174EF128 for ; Mon, 19 Oct 2026 12:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792412667; cv=none; b=GmS72M2Yjg+vbDPHrF3SiSYOxpmchJgWqCl7hFkY1MSUSNpiJ7alsolpQ7JSRifJc6RxdbB4YAXFGK6lqDpjRjkLlmfc1R89gWXooGO4l3RlpkL+BvykpgPobjoGb2zLwYQYlAON9YQCHBZl3JwSwOJzG82qvu368Fqg8re2Ftk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792412667; c=relaxed/simple; bh=wd28aU++NdtOMWUJjRpk6EgNkx6fD22f8iP3kR6CsIA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OPxTZe5BxQcG2E51gQBoHHaWgOGPGO5hSAxCDDtN0D0AJ0AJMvGzO7s9QrU6wT0lfdDBEFBcQsb7J0USvypzb73/rC79VY2Ba3+AFteRG3WYQTGQLZcwDgtt3xC1uE0b1RYqtfkdMDiiV6cD1k7w6jnvaS3RyPJFk/gYBrginBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=JUXP5CJy; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="JUXP5CJy" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4980fe6b3beso19435385e9.0 for ; Mon, 19 Oct 2026 05:24:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1792412662; x=1793017462; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=nCKEluHSWIFV51AHkRVTAd1QNSpPxxkrgvIjhQ5PXZk=; b=JUXP5CJyrMMjFmxa6xvURwQ3HJqNbCgVeoE9kApk/C3I8HLhyl6yflZvAtMPXTbAbq PZmVdIkjgqkqPo4RBL3iXj4+Gv2vfkhp8mEoTc33nuYx/hC6QXCdrRdFdxYQiAp6RAU7 litVm9pJum2csacPR5Zeg6plHlt+ugelXA5+PbJRS63T3gFZ6csA36ec4bpqXebWJwBd /g8y/2cG9NKDw2mWEwo+Ctcx7a2skfoul49FHdgE2SthiXa/M1Rozb9lLYr8z9tqOtHB 77rDdIM6UWUgYOc2WCdMXwRd4LIffiEiFux2eOgCF167Foas27W9/Py+bOht9IgfvYL7 +EIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792412662; x=1793017462; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nCKEluHSWIFV51AHkRVTAd1QNSpPxxkrgvIjhQ5PXZk=; b=adj9lmnqsHJsmD1HmkszhLY+fsZ2W1yy34VlBHSgFXaMmDf87qfweWBcKLKtLF3idS bGljatLSraRS0r+6XBA3uj1DaiBKVkBriZvs/kH847Q5W2/yjKJH+m8IezK8hovK+hvk T1/OdLjBdjRQGVaVg8H7OJIOmRqnXrb6pGb6d+yYQR58f6kx65jN35vrtc0bUTOOXp7Q NRxzZeMpyPeTuP1HkuWMhbL6VushUkZ/cVxOMjO6nJsEmJL8VbnOIQXhk2QB+DNE4uHW UsH8DlPYACFVtnAGrgTTBfjnuyDmFkHeKL4OR/tpeLPO8XzAeS9KFgtMxigWDbQhezk0 a5Bw== X-Forwarded-Encrypted: i=1; AKwUvBxQObtKmvwP+e9OnLa8c96wLXiudjEhjxcdLk/MJtzMOFEI2XOIR1I5JYEx245yeFGetz6fN13btM86RTY=@vger.kernel.org X-Gm-Message-State: AFq9FYInlsXfXE/dUebnRgAqf8rAhMUakxCoHTowALaE0uueV0Aucghs dF8gi/QoE1xUI8bNIhF/sler+kkATPDw2IW13rMYVuCeklfNc//mzxjz3wFVr0ahyR0= X-Gm-Gg: AYBFou2NicFm30Lg6PrWz7n1uYAjE2bUpiET/Y5t9MieNJ7w+BIt3t1DZQoIMfhXIF/ P6qrpRjDPLkwnvJyXH0qfnZruJvNhGHRUY3tKHHpn1+W/J+pkXvRe1iR/hI1sCpe7/+JzbvDYYK DqZfyEUIMWT9Dx0c42cADamtErK2Zu/zHTKx5tGLrGX/wfheIZCwD9JcB5J5Dn7d0uwuaLTKLVB wWJqmuOy74AFXQC282uAe8i53vbLy71pxh0qZQSr6nMVsBgqB2RQXW98IRR5Y0QkVeW8uy1NLqU BFfDwuCtsf17iUpwBp10wQ0OtHZ/PglD/UDiBhPm0sQ8bYxMSs2ZXgTCY9/0F2wUR5ZdTX4wGCD PJsKPqvxg/Ix0jojZZuAJnNHHsEO2SHiSKrNzNj+knVBuc6NqwaLrkbLHpndR5LdO3/q8/2jHbe fk8y/LliIXw9aTqXGmDFcEZ/ObO7QkC4C/2Ly35Jyu1/LFJM6FLxPgoSVcQgcogGXokk1Uz3JhN o1fXGOb7lnIxCDzsPRDoFD4p1Gre8/3Y9a8Z5IfSqSwMl6dvLJig+Np8sBdQBnerwHSWQiFizca WlDf0xGKdXnZQaRtDcZaBc1Ok6jgxghyjf5fyAN53+XQDATs2wq/5XGB/7I= X-Received: by 2002:a05:600c:3484:b0:4a0:34a:588c with SMTP id 5b1f17b1804b1-4a1d7605e04mr161218185e9.14.1792412661854; Mon, 19 Oct 2026 05:24:21 -0700 (PDT) Received: from aspen.lan (aztw-33-b2-v4wan-169864-cust3247.vm26.cable.virginm.net. [92.239.204.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1dc8ee409sm284385915e9.13.2026.10.19.05.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2026 05:24:20 -0700 (PDT) Date: Mon, 19 Oct 2026 13:24:18 +0100 From: Daniel Thompson To: Luka Panio Cc: lee@kernel.org, danielt@kernel.org, jingoohan1@gmail.com, pavel@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, deller@gmx.de, krzk@kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, junjie.cao@linux.dev, mitltlatltl@gmail.com Subject: Re: [PATCH 0/2] backlight: Add Awinic AW99703 driver Message-ID: References: <20261016162912.64581-1-lukapanio@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Oct 19, 2026 at 01:26:21PM +0200, Luka Panio wrote: > Hi Daniel, Krzysztof, > > Thanks for the reviews. Before reworking this for v2 I'd like to agree > on the approach. > > Following Daniel's suggestion I'll add AW99703 support to the aw99706 > driver using per-chip data instead of adding a new driver. The register > maps differ almost entirely, so most of the DT properties stay > per-chip (dim-mode/UVLO/ramp-ctl on AW99706, OVP/OCP/inductor on > AW99703). > > Following Krzysztof's review, the AW99703 binding will drop the > ramp/transition timing and mapping properties and use the standard > led-sources and led-max-microamp properties. > > That leaves the one common property, the maximum LED current, > spelled differently in a single driver: awinic,iled-max-microamp for > AW99706 and led-max-microamp for AW99703. To avoid that I'd like to: > > - add led-max-microamp to awinic,aw99706.yaml and mark > awinic,iled-max-microamp as deprecated > - have the driver read led-max-microamp for both chips, falling back > to awinic,iled-max-microamp on AW99706 so existing DTs keep working > > Does that sound acceptable? IIUC you plan to improve the binding for AW99706 before adding AW99703 support, and you will keep the old DT property working to that existing DTBs continue to work? Both sound good to me. Daniel.