From: "Alvin Šipraga" <alvin.sipraga@analog.com>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: Linus Walleij <linusw@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: realtek: use <module>-y in Makefile
Date: Mon, 19 Oct 2026 15:00:59 +0200 [thread overview]
Message-ID: <atYUg6WwuxF32LJc@analog.com> (raw)
In-Reply-To: <20261019-realtek_mkf-v1-1-3246a77d5782@gmail.com>
On Mon, Oct 19, 2026 at 01:26:27AM -0300, Luiz Angelo Daros de Luca wrote:
> Switch from <module>-objs to <module>-y to eliminate ifdefs and simplify
> conditional object list construction. Drop the obsolete trailing
> comment.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Reviewed-by: Alvin Šipraga <alvin.sipraga@analog.com>
> ---
> drivers/net/dsa/realtek/Makefile | 28 ++++++++++------------------
> 1 file changed, 10 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/net/dsa/realtek/Makefile b/drivers/net/dsa/realtek/Makefile
> index 72bb42e80c95..0a94a619b2c1 100644
> --- a/drivers/net/dsa/realtek/Makefile
> +++ b/drivers/net/dsa/realtek/Makefile
> @@ -1,23 +1,15 @@
> # SPDX-License-Identifier: GPL-2.0
> obj-$(CONFIG_NET_DSA_REALTEK) += realtek_dsa.o
> -realtek_dsa-objs := rtl83xx.o
> -
> -ifdef CONFIG_NET_DSA_REALTEK_MDIO
> -realtek_dsa-objs += realtek-mdio.o
> -endif
> -
> -ifdef CONFIG_NET_DSA_REALTEK_SMI
> -realtek_dsa-objs += realtek-smi.o
> -endif
> +realtek_dsa-y := rtl83xx.o
> +realtek_dsa-$(CONFIG_NET_DSA_REALTEK_MDIO) += realtek-mdio.o
> +realtek_dsa-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek-smi.o
>
> obj-$(CONFIG_NET_DSA_REALTEK_RTL8366RB) += rtl8366.o
> -rtl8366-objs := rtl8366-core.o rtl8366rb.o
> -ifdef CONFIG_NET_DSA_REALTEK_RTL8366RB_LEDS
> -rtl8366-objs += rtl8366rb-leds.o
> -endif
> +rtl8366-y := rtl8366-core.o rtl8366rb.o
> +rtl8366-$(CONFIG_NET_DSA_REALTEK_RTL8366RB_LEDS) += rtl8366rb-leds.o
> +
> obj-$(CONFIG_NET_DSA_REALTEK_RTL8365MB) += rtl8365mb.o
> -rtl8365mb-objs := rtl8365mb_main.o \
> - rtl8365mb_table.o \
> - rtl8365mb_vlan.o \
> - rtl8365mb_l2.o \
> -# end of rtl8365mb-objs
> +rtl8365mb-y := rtl8365mb_main.o \
> + rtl8365mb_table.o \
> + rtl8365mb_vlan.o \
> + rtl8365mb_l2.o
>
> ---
> base-commit: 98c2ad4f5d805dbc1ea436a334ee59311806a48c
> change-id: 20261019-realtek_mkf-380d67738b1d
>
> Best regards,
> --
> Luiz Angelo Daros de Luca <luizluca@gmail.com>
>
prev parent reply other threads:[~2026-10-19 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 4:26 Luiz Angelo Daros de Luca
2026-10-19 13:00 ` Alvin Šipraga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atYUg6WwuxF32LJc@analog.com \
--to=alvin.sipraga@analog.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®