From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03DE74F390B for ; Mon, 19 Oct 2026 13:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792415326; cv=none; b=Xi6ExL94TApiA1nfiBZ0whIV2PgpGtSM0vPpnd5QC1V18CjcMe7fyM6+NRjdUoL9HWsQRy5EoWyTr5khX77MJGERSCUEBOpUqhkKgnO47R9btbMy/Pq7rn8bZxhTez0SN6XuQQNN4ZXlr1/T8fONwX3RKnAy8I2/cgWhfJFpc7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792415326; c=relaxed/simple; bh=6n04UjmHWzHkRI2pU81sYk4TGUvABFkPV8ul8H4khJc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aNTP02jn8xlNIVY+etypttnehrWE6TOJSZu/RR0k4hjVgBIPUb1yt7hWtVECsS2g21rKhnmBpfSUAIi+FcDQcQeEkT0q5seLTk3nYYDEHNxcbcBkUMWeridrIGovWh6tdqoq4ScIRiGbhnlGVzebyq+IcHuddzcXBgiiKUXnnrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V5C0rCwh; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V5C0rCwh" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4a1cef0439aso22665605e9.0 for ; Mon, 19 Oct 2026 06:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792415323; x=1793020123; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=vTQAPwM+cnw+xqrbQuZPi16xVs48V+krw0MsL6q3+zM=; b=V5C0rCwhAEbMYRgw5cI6JESIJDR7L8tJpfRch3GmnL5Lnhi+yF/y1oigkXx+ZgEQI7 SdIPuBNz6rrAsk/cQOYPEWD/jTgtZSlDbDJugVoU2hgf0Il36Q5JPKmqe3Z3w/gFyEB1 Hbex/mfa1Z7bywpIGRfaP7pLwCYe/QWuMyzAKXBmJFo7mZJoFfCWkCVDld+bRD4YQuym l/LXI71wEwctd1YuWtOC5gUBVJRZ70VbUP/xx68iVsdGBTT+2QUDHhsJ6TuGHwrnZV7A VEIC8EeahShy2EvhVtQz1moTW1YY4J5hnaDUr8uVH5D8K6SQOsIBM+FcwMhPvIi/TK0k s2gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792415323; x=1793020123; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vTQAPwM+cnw+xqrbQuZPi16xVs48V+krw0MsL6q3+zM=; b=PTqxeJ2HUWasvc8OxGL4zlh6HUKBE5B2NZfPXF+NYbc5ODFc+R00FZvMNZQmmX3taE nKap4g3BWDfRNq/al9LzTYYt0AOvIvVlARnG7ym70tzKNibIPY93NlK+/nlrqdt4Eq1f FhSmi2Em05l5ZHI0hPVQq639LyXSafKVGQ4SvkJYuD91b1jPhnfrDV53B1eW68BDSivZ KziGSNBXDYlQqK4CozrznmIvGs6Fb2yHalpw1IRiiq8VEn0+GltmBOLBh9YXTYvR8xtN kP2AdhhTf75GL2GKgiS9tnTUkhDCqLeucLc68c5Iqn+XPUtTqcjfN6idblHT8rD/xu7V LjDA== X-Forwarded-Encrypted: i=1; AKwUvBz9hoAaN+nbjWLt6i2me7a2MDFDG8s03PtM0Te5QZ1bNQP0sE3KF4sZZwOyqaWjTpXjfsA8hlxJbE4mXkU=@vger.kernel.org X-Gm-Message-State: AFq9FYJO9E9PFyOzTeJLOd0RxEKq5hd/AviztfojER7mmiXwP9rd/zgm 3hg+umqO1DLpICsQ55mlBZUc9pOEwkRxYuRczW2Jf0V8iwJR5aqNGOOs3bTchUY= X-Gm-Gg: AYBFou2dPXoDJzhWPawpCbTBX/k+GoG5Zh9IssCX2Qm7CBVJAnoaxZFeiCttC/YExWw HLJkeerr/viZ9tk9A8jc5IKW7ZiitkVHCmx+Q2+UzaAClOhOuvDrwSjUXYOFzBpKtdX++2RXzPt O5DPb3uQ6v+WfG+8DQFqWFzfTD9SIN08VMIsRNw2ksvjLnJc+lBg3YMCKDD96EGaV7vtwT8E2d9 t9zcp72L4IRCzNHnuJyvYWw4s9eor25t3lINmr8Rno3hvGN+eKKJcEPiEoEUJQTpjta8QPKyOZz sYh/D/lx4LbPSS4ffQyw0iPHQEDs22JjniZT+oGkUOs62GuOgex3TzLixL9HJmFk5dGw/SjIf3L RUlPs7HS2McbMGMZCjJRSVnSEbA6cx0HKpJTWLwhHW1gHMGgrJg6ZyFt0x2Q64AbErTliQrfdDJ 5Dwhu7FUiDt7bYluID7mUHJd6pNiN8SbnMvSdHMg+SZrx+iLLGBeLAUh9dPOrvNcfWkPgT6osEY hI95qqiFLTCZ1+vg6rUDgJ+JY3UfU9az5gTUEb1vpiTQVIQAkKWFgpBOI6tzw== X-Received: by 2002:a05:600c:8485:b0:4a1:d7c3:d3d with SMTP id 5b1f17b1804b1-4a1ef992f33mr17017955e9.10.1792415322800; Mon, 19 Oct 2026 06:08:42 -0700 (PDT) Received: from lithos ([2a02:810d:4a94:b300:7ea2:632d:ad2b:6944]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd4f8d12sm23659618f8f.36.2026.10.19.06.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2026 06:08:42 -0700 (PDT) Date: Mon, 19 Oct 2026 15:08:37 +0200 From: Florian Fuchs To: Daniel Palmer Cc: ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, dlemoal@kernel.org, cassel@kernel.org, linux-sh@vger.kernel.org, linux-ide@vger.kernel.org, geert@linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ata: pata_artop: read the ATP865 mode register through pci_iomap Message-ID: References: <20261017041419.311921-1-daniel@0x0f.com> <20261017041419.311921-2-daniel@0x0f.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261017041419.311921-2-daniel@0x0f.com> Hi Daniel, On 17 Oct 13:14, Daniel Palmer wrote: > artop_init_one() probes the 6280's "fast" bit with inb() on the raw > start address of BAR 4. That address is a PCI I/O address, which is > only a usable port number on platforms whose I/O port base maps PCI I/O > space one to one. On an SH7751 LANDISK (identity io_port_base, PCI I/O > window at 0xfe240000) the resource starts at 0x1400 and inb(0x1400) > dereferences that address: > > BUG: unable to handle kernel paging request at 00001400 > PC is at artop_init_one+0x10e/0x170 > > Map the BAR with pci_iomap() and use ioread8(), as libata-sff does for > the BMDMA registers later on. > > Signed-off-by: Daniel Palmer > --- > drivers/ata/pata_artop.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c > index 9f8d41639a62..351ff4c8e48e 100644 > --- a/drivers/ata/pata_artop.c > +++ b/drivers/ata/pata_artop.c > @@ -405,13 +405,21 @@ static int artop_init_one (struct pci_dev *pdev, const struct pci_device_id *id) > case 1: /* 6260 */ > ppi[0] = &info_626x; > break; > - case 2: /* 6280 or 6280 + fast */ > - if (inb(pci_resource_start(pdev, 4)) & 0x10) > + case 2: { /* 6280 or 6280 + fast */ > + void __iomem *bmdma = pci_iomap(pdev, 4, 1); > + u8 cfg; > + > + if (!bmdma) > + return -ENOMEM; > + cfg = ioread8(bmdma); > + pci_iounmap(pdev, bmdma); > + if (cfg & 0x10) > ppi[0] = &info_628x_fast; > else > ppi[0] = &info_628x; > break; > } > + } > > BUG_ON(ppi[0] == NULL); > > -- > 2.55.0 > There is a small logic change, where -ENOMEM is returned, when BAR 4 is unassigned, where libata would fallback to PIO [0], so maybe it shouldn't fail when BAR 4 is unassigned? Tested-by: Florian Fuchs # on PX-EH40L (LANDISK HDL-U, ATP865 1191:0009 rev 10) I also tested forced PIO4 mode via libata.force=pio4, which also works on the device. (ata1.00: FORCE: xfer_mask set to pio4) [0] https://github.com/torvalds/linux/blob/master/drivers/ata/libata-sff.c#L3088 Regards Florian