Re: [PATCH 1/7] dt-bindings: input: touchscreen: samsung,s6sy761: Add S6SY791 and reset GPIO

[Lukas Timmermann <linux@timmermann.space>]

On Mon, Oct 12, 2026 at 01:30:48PM +0200, Krzysztof Kozlowski wrote:
> On 11/10/2026 14:44, Lukas Timmermann wrote:
> > S6SY791 is the SPI-based counterpart of S6SY761. The register map and
> > commands are identical for the subset the kernel currently implements.
> > Therefore add S6SY791 as a related touch controller.
> > 
> > Optionally, the reset line can be controlled on some boards,
> > such as the Google Pixel 6 Pro (raven).
> > 
> > Also reference spi-peripheral-props for the SPI bus properties.
> > 
> > Signed-off-by: Lukas Timmermann <foss@timmermann.space>
> > ---
> >  .../input/touchscreen/samsung,s6sy761.yaml         | 37 +++++++++++++++++++++-
> >  1 file changed, 36 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml b/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml
> > index 1ffd17af3c53..d24f35038934 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml
> > @@ -8,13 +8,17 @@ title: Samsung S6SY761 touchscreen controller
> >  
> >  maintainers:
> >    - Andi Shyti <andi.shyti@kernel.org>
> > +  - Lukas Timmermann <foss@timmermann.space>
> >  
> >  allOf:
> >    - $ref: touchscreen.yaml#
> > +  - $ref: /schemas/spi/spi-peripheral-props.yaml#

Should I also hide this behind an if-else? 

> >  
> >  properties:
> >    compatible:
> > -    const: samsung,s6sy761
> > +    enum:
> > +      - samsung,s6sy761
> > +      - samsung,s6sy791
> >  
> >    reg:
> >      maxItems: 1
> > @@ -22,9 +26,19 @@ properties:
> >    interrupts:
> >      maxItems: 1
> >  
> > +  reset-gpios:
> > +    maxItems: 1
> > +    description: GPIO connected to the reset pin of the controller
> > +
> >    avdd-supply: true
> >    vdd-supply: true
> >  
> > +  spi-max-frequency: true
> 
> Drop
> 

Noted.

> > +
> > +  spi-cpha: true
> > +
> > +  spi-cpol: true
> 
> These two should be probably required for the new device.
> 

Thanks.

Best regards,
Lukas