From: Jarkko Sakkinen <jarkko@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org, stable@vger.kernel.org,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Andrew Morton <akpm@osdl.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/6] KEYS: Prevent overflow of quota in key_alloc()
Date: Mon, 19 Oct 2026 23:56:51 +0300 [thread overview]
Message-ID: <ataEE0zcWy8ILlms@kernel.org> (raw)
In-Reply-To: <ataDs4TMkbRjxc_G@kernel.org>
On Mon, Oct 19, 2026 at 11:55:19PM +0300, Jarkko Sakkinen wrote:
> On Mon, Oct 19, 2026 at 12:25:45PM -0700, Eric Biggers wrote:
> > On Mon, Oct 19, 2026 at 09:17:24PM +0300, Jarkko Sakkinen wrote:
> > > Check that the calculated quota length does not go over INT_MAX.
> > >
> > > Cc: stable@vger.kernel.org
> > > Assisted-by: LLM
> > > Fixes: 7e047ef5fe2d ("[PATCH] keys: sort out key quota system")
> > > Reviewed-by: David Howells <dhowells@redhat.com>
> > > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> >
> > Seems this should be merged into patch 3?
> >
> > Also is this reachable? I.e. do any of the key types actually specify
> > def_datalen > INT_MAX - KEY_MAX_DESC_SIZE + 1?
>
> This is very good question and my *guess* is that no there is not.
>
> That said, when not treated as a bug fix this patch is a great
> safe-guard e.g., to block corraterall effects of some other
> bugs.
>
> So yeah, that's I would propose here. Let's not call it a bug fix
> but still merge.
Or actually: no let's not do this. I'm making my life only more
difficult.
I think it is totally sane to squash this to patch 3 and it
is reasonable for that fix have this additional safe-guard.
Br, Jarkko
next prev parent reply other threads:[~2026-10-19 20:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 18:17 [PATCH v2 0/6] KEYS: rhashtable bug fixes Jarkko Sakkinen
2026-10-19 18:17 ` [PATCH v2 1/6] KEYS: Expand key->{datalen,quotalen} to unsigned int Jarkko Sakkinen
2026-10-19 19:12 ` Eric Biggers
2026-10-19 20:32 ` Jarkko Sakkinen
2026-10-19 18:17 ` [PATCH v2 2/6] KEYS: Reject @desclen values >= KEY_MAX_DESC_SIZE in key_alloc() Jarkko Sakkinen
2026-10-19 19:17 ` Eric Biggers
2026-10-19 20:46 ` Jarkko Sakkinen
2026-10-20 0:19 ` Jarkko Sakkinen
2026-10-19 18:17 ` [PATCH v2 3/6] KEYS: Prevent overflow of user->{qnkeys,qnbytes} " Jarkko Sakkinen
2026-10-19 19:23 ` Eric Biggers
2026-10-19 20:53 ` Jarkko Sakkinen
2026-10-20 0:26 ` Jarkko Sakkinen
2026-10-19 18:17 ` [PATCH v2 4/6] KEYS: Prevent overflow of quota " Jarkko Sakkinen
2026-10-19 19:25 ` Eric Biggers
2026-10-19 20:55 ` Jarkko Sakkinen
2026-10-19 20:56 ` Jarkko Sakkinen [this message]
2026-10-19 18:17 ` [PATCH v2 5/6] KEYS: Reject @datalen values over INT_MAX Jarkko Sakkinen
2026-10-19 19:31 ` Eric Biggers
2026-10-19 21:07 ` Jarkko Sakkinen
2026-10-19 23:55 ` Jarkko Sakkinen
2026-10-20 0:03 ` Jarkko Sakkinen
2026-10-19 18:17 ` [PATCH v2 6/6] KEYS: Verify the key identity in __keyctl_unlink Jarkko Sakkinen
2026-10-19 19:35 ` Eric Biggers
2026-10-19 21:06 ` Jarkko Sakkinen
2026-10-19 21:16 ` Jarkko Sakkinen
2026-10-19 18:29 ` [PATCH v2 0/6] KEYS: rhashtable bug fixes Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ataEE0zcWy8ILlms@kernel.org \
--to=jarkko@kernel.org \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®