From: Brian Masney <bmasney@redhat.com>
To: Xincheng Ji <jixincheng@ultrarisc.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Bjorn Andersson <andersson@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Jia Wang <wangjia@ultrarisc.com>
Subject: Re: [PATCH v2] clk: ultrarisc: Register DP1000 clock provider earlier
Date: Mon, 19 Oct 2026 18:01:34 -0400 [thread overview]
Message-ID: <ataTPiXwPV9n7PAx@redhat.com> (raw)
In-Reply-To: <20261014-ultrarisc-clock-fix-v2-1-bd126723a42c@ultrarisc.com>
On Wed, Oct 14, 2026 at 11:20:12AM +0800, Xincheng Ji wrote:
> From: Jia Wang <wangjia@ultrarisc.com>
>
> The DP1000 PCIe and clock drivers both register at the device initcall
> level. Since the PCIe driver is linked first, its probe runs before the
> clock provider is available and defers.
>
> sysfb_init() runs at the same initcall level before deferred probes are
> retried. It claims the firmware framebuffer aperture, so the later PCIe
> host probe cannot allocate the overlapping prefetchable window and the
> GPU is not enumerated.
>
> Use subsys_platform_driver() to register the clock provider at the
> subsys_initcall level when built in so PCIe host probing completes before
> sysfb_init(). The helper keeps the normal module init and exit paths when
> the driver is built as a module.
>
> Fixes: 3948a36be42b ("clk: ultrarisc: Add DP1000 clock driver")
> Signed-off-by: Jia Wang <wangjia@ultrarisc.com>
> Signed-off-by: Xincheng Ji <jixincheng@ultrarisc.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
So we are going to hold off on sending this in for v7.4, and I'll merge
this into clk-next once rc1 comes out in a few weeks. My series for
subsys_platform_driver() was merged through the qcom clk tree, which is
in the clk-qcom branch. With the way we do branching the clk tree won't
stay bisectable if I merge this through clk-pile.
This shouldn't cause any issues other than a slower boot. If it's
causing other issues, then that's a separate issue that also needs to be
fixed.
Brian
prev parent reply other threads:[~2026-10-19 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 3:20 Xincheng Ji
2026-10-19 22:01 ` Brian Masney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ataTPiXwPV9n7PAx@redhat.com \
--to=bmasney@redhat.com \
--cc=andersson@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=jbrunet+clk@baylibre.com \
--cc=jixincheng@ultrarisc.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=wangjia@ultrarisc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®