From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792493455; b=Wauv8wGqXdHAvDmhN21Mnz5qaurWKykZIGWMp0RRC9M3+d0mQCM6/bDRXQUrBSrxoAj5 bq0j7HjPnakfYEL4kh6glsrv16kNTCpOb0MnLVkA5eKINgWFSeIdDEAnogjOZlsD8ez7O CLvBT7rk6Ug9UaG5ZnnHxt3o6Pnd7+uP4T423DGcXc9g8e8IVLcJiw8SdABu2sjyRZIkf r73QK2EjSPfk2Vjb1mIGluYWNKnkc/dMArLkYVRkUAm2HhbYz35/s7yrjrcIv2eX9FYHl 4fLJi3V2tKN+ZQO3gJDq3Bmr+p6ZczYf0ynYhyHBQEYTulti0VV6wQmUsNn6AmNwc8g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792493455; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:Date:From:To:Cc:Subject: Message-ID:References:MIME-Version:Content-Type:Content-Disposition: Content-Transfer-Encoding:In-Reply-To:X-Scanned-By; bh=JANbW0OsMsiIZhYIihCc20hPsaNmoKXg98JEd0I6bjw=; b=W24rPqak3LUJ87SD0JO7C6Z8scoJ9Di69yruLpCLbkah2WxOJt4POS3o6EwzBg1bXpkZ U5nO3zYVjxHwYEkV/XX9XM6n1EG749jZwTb7d5/N3a8TMkX1fGfFpbOji6tClVUmc0D44 0n9ekyWaj8Yvkmjg/ndyvhiY/+zIX0RLNg+6YIpaq+Jq9qo5YTSvhrtnwGtNtlyBi7G+K FNtbMTCl4hwcsOnQPStGHOLSyuCtNkUShNx6vcMgC2D+0XHV2CXdqy6ZS9yJFmfUaIh00 QnFtxegh2nSTSwFNq8hkPlKk9oD8NEdw41lO3H45/UC1s27ezoeb3sMwnhv6QRkGQeQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b="I/eySZnY"; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAC79606A31E for ; Tue, 20 Oct 2026 10:50:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EAC79606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=I/eySZnY DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792493454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JANbW0OsMsiIZhYIihCc20hPsaNmoKXg98JEd0I6bjw=; b=I/eySZnYhvSK4q3f9XD0XqVpk1V2XNc4RIsTPxqWkPAc4lxMZ0if7tZsrnbjBE86m+ggkK Eu2TsTVrOftqASVeCDKIKRkbub8fCNnE4Vn/vOIfsogKQQkhJT0O4X46q4okKfd8Xa4xY6 Igi63C/m71hRg8sDjq7fnPPdkLN8UC8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-d1ZaYW2ONtaZUUzoThD6KQ-1; Tue, 20 Oct 2026 10:50:50 +0000 X-MC-Unique: d1ZaYW2ONtaZUUzoThD6KQ-1 X-Mimecast-MFC-AGG-ID: d1ZaYW2ONtaZUUzoThD6KQ_1792493449 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 513181800655; Tue, 20 Oct 2026 10:50:49 +0000 (UTC) Received: from bfoster (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CEF391956088; Tue, 20 Oct 2026 10:50:47 +0000 (UTC) Date: Tue, 20 Oct 2026 06:50:45 -0400 From: Brian Foster To: Nickolai Zeldovich Cc: Matthew Wilcox , Jan Kara , Andrew Morton , Theodore Ts'o , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] mm/truncate: fix the zeroing end of pagecache_isize_extended() Message-ID: References: <20261016222721.791785-1-nickolai@csail.mit.edu> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Mon, Oct 19, 2026 at 03:54:14PM -0400, Nickolai Zeldovich wrote: > On Mon, Oct 19, 2026 at 3:35 PM Brian Foster wrote: > > > --- a/mm/truncate.c > > > +++ b/mm/truncate.c > > > @@ -878,8 +878,7 @@ void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to) > > > unsigned int offset, end; > > > > > > offset = from - folio_pos(folio); > > > - end = min_t(unsigned int, to - folio_pos(folio), > > > - folio_size(folio)); > > > + end = min_t(loff_t, to - folio_pos(folio), folio_size(folio)); > > > > Good catch... > > > > folio_size() returns size_t and folio_zero_segment() expects size_t for > > the offset params. Perhaps we should that instead of loff_t? > > size_t is (unsigned int) on 32-bit machines, like i386, which has the > same issue (reproducer from the patch). > Ah, Ok. So loff_t makes sense for the min_t(). I do still wonder if it makes sense to switch offset and end to size_t while we're here though. Brian