mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thorsten Blum <blum@kernel.org>
To: Sourabh Jain <sourabhjain@linux.ibm.com>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	Aditya Gupta <adityag@linux.ibm.com>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Jinjie Ruan <ruanjinjie@huawei.com>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/kexec_file: Simplify add_usable_mem()
Date: Tue, 20 Oct 2026 13:59:05 +0200	[thread overview]
Message-ID: <atdXiXc_ZtCS9fhi@kernel.org> (raw)
In-Reply-To: <eff3cd57-7b84-4718-85ef-e1fa1c6ad4e3@linux.ibm.com>

Hi Sourabh,

On Fri, Sep 25, 2026 at 01:04:52PM +0530, Sourabh Jain wrote:
> On 16/09/26 21:01, Thorsten Blum wrote:
> > Use max() and min() to calculate loc_base and loc_end, respectively.
> > Skip to the next range if loc_base > loc_end and drop the now-obsolete
> > boolean add variable.
> > 
> > Signed-off-by: Thorsten Blum <blum@kernel.org>
> > ---
> >   arch/powerpc/kexec/file_load_64.c | 29 +++++++++--------------------
> >   1 file changed, 9 insertions(+), 20 deletions(-)

[...]

> So, the changes look good to me. Feel free to add:
> 
> Reviewed-by: Sourabh Jain sourabhjain@linux.ibm.com

Thank you for your review. This should have been:

  Reviewed-by: Sourabh Jain <sourabhjain@linux.ibm.com>

Without angle brackets <..>, b4 ignores the tag:

NOTE: some trailers ignored due to from/email mismatches:
    ! Trailer: Reviewed-by: Sourabh Jain sourabhjain@linux.ibm.com
     Msg From: Sourabh Jain <sourabhjain@linux.ibm.com>

Thanks,
Thorsten

      reply	other threads:[~2026-10-20 11:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 15:31 Thorsten Blum
2026-09-25  7:34 ` Sourabh Jain
2026-10-20 11:59   ` Thorsten Blum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atdXiXc_ZtCS9fhi@kernel.org \
    --to=blum@kernel.org \
    --cc=adityag@linux.ibm.com \
    --cc=chleroy@kernel.org \
    --cc=hbathini@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=ruanjinjie@huawei.com \
    --cc=sourabhjain@linux.ibm.com \
    --cc=sshegde@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®