From: Kiryl Shutsemau <kas@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Lance Yang <lance.yang@linux.dev>,
samarth.colleges@gmail.com, akpm@linux-foundation.org,
xu.xin@linux.dev, chengming.zhou@linux.dev, peterx@redhat.com,
rppt@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] mm/ksm: keep soft-dirty and uffd-wp when merging a page
Date: Wed, 21 Oct 2026 09:55:50 +0100 [thread overview]
Message-ID: <ath8JTlITYcXsyLg@thinkstation> (raw)
In-Reply-To: <68f17ee7-d272-4475-8a59-645442e2c210@kernel.org>
On Wed, Oct 21, 2026 at 10:21:53AM +0200, David Hildenbrand (Arm) wrote:
> > +1. Did it ever actually work there :) Why not just skip them and
> > call it a day :D
>
> I think QEMU just always sets MADV_MERGABLE and later activates uffd. So that
> needs some care to not disable them. So let's rather try to get it fixed properly.
>
> Can you send out proper patches? Thanks!
+1.
Lance's direction is right. Unsharing is not an access: do_wp_page()
already skips the uffd-wp fault on FAULT_FLAG_UNSHARE, and RWP should do
the same.
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2026-10-21 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 1:09 Samarth Narang
2026-10-19 2:07 ` Lance Yang
2026-10-19 13:24 ` David Hildenbrand (Arm)
2026-10-20 5:55 ` Lance Yang
2026-10-20 13:03 ` David Hildenbrand (Arm)
2026-10-20 13:29 ` Lance Yang
2026-10-21 8:21 ` David Hildenbrand (Arm)
2026-10-21 8:55 ` Kiryl Shutsemau [this message]
2026-10-20 21:58 ` Mohammed EL Kadiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ath8JTlITYcXsyLg@thinkstation \
--to=kas@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=david@kernel.org \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=samarth.colleges@gmail.com \
--cc=stable@vger.kernel.org \
--cc=xu.xin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®