From: Florian Westphal <fw@strlen.de>
To: Julius Bairaktaris <julius@bairaktaris.de>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
phil@nwl.cc, coreteam@netfilter.org, netdev@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, andrew+netdev@lunn.ch,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, nbd@nbd.name
Subject: Re: [PATCH nf-next 2/3] netfilter: flowtable: update upper device stats in the fast path
Date: Wed, 21 Oct 2026 10:08:20 +0200 [thread overview]
Message-ID: <athy9HUHBPfCBKu6@strlen.de> (raw)
In-Reply-To: <20261018025319.1445197-1-julius@bairaktaris.de>
Julius Bairaktaris <julius@bairaktaris.de> wrote:
> On Sun, Oct 18, 2026 at 03:53:40AM +0200, Pablo Neira Ayuso wrote:
> > I mentioned it is a feature that these counters are not bumped,
> > because packets are not passing through this devices in the bypass.
> >
> > This allows users to see what packets follow classic path?
+1
> OpenWrt users report it as a bug. On my router a 268 MB download moved
> 0.15 MB on br-lan, while the port below it counted all of it.
Whats your plan when users report the proposed new behaviour (always
account to the virtual parent device) as a bug?
Conceptually, with flowtable, offloaded packets bypass that device entirely
and therefore should not touch stats of the virtual device. At least
thats how I'd expect it to behave.
next prev parent reply other threads:[~2026-10-21 8:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 17:16 [PATCH nf-next 0/3] " Julius Bairaktaris
2026-10-04 17:16 ` [PATCH nf-next 1/3] 8021q: add vlan_dev_sw_netstats_rx_add() and vlan_dev_sw_netstats_tx_add() Julius Bairaktaris
2026-10-04 17:16 ` [PATCH nf-next 2/3] netfilter: flowtable: update upper device stats in the fast path Julius Bairaktaris
2026-10-18 1:53 ` Pablo Neira Ayuso
2026-10-18 2:53 ` Julius Bairaktaris
2026-10-21 8:08 ` Florian Westphal [this message]
2026-10-21 9:51 ` Julius Bairaktaris
2026-10-04 17:16 ` [PATCH nf-next 3/3] selftests: netfilter: nft_flowtable.sh: check upper device counters Julius Bairaktaris
2026-10-17 10:37 ` [PATCH nf-next 0/3] netfilter: flowtable: update upper device stats in the fast path Julius Bairaktaris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=athy9HUHBPfCBKu6@strlen.de \
--to=fw@strlen.de \
--cc=andrew+netdev@lunn.ch \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=julius@bairaktaris.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®