From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Yixun Lan" <dlan@kernel.org>, "Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>, "Frank Li" <Frank.Li@nxp.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Niklas Cassel" <cassel@kernel.org>,
"Christian Bruel" <christian.bruel@foss.st.com>,
"Senchuan Zhang" <zhangsenchuan@eswincomputing.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Randolph Lin" <randolph@andestech.com>,
"Xincheng Zhang" <zhangxincheng@ultrarisc.com>,
"Alex Elder" <elder@riscstar.com>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Marek Vasut" <marek.vasut+renesas@mailbox.org>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Pengpeng Hou" <pengpeng@iscas.ac.cn>,
"Anirudh Srinivasan" <asrinivasan@oss.tenstorrent.com>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, "Yixun Lan" <dlan@gentoo.org>,
"Longbin Li" <looong.bin@gmail.com>
Subject: Re: [PATCH v7 1/6] PCI: spacemit-k1: Add device data support
Date: Wed, 21 Oct 2026 12:12:15 +0300 [thread overview]
Message-ID: <atiB7-u5bxJbf-1q@ashevche-desk.local> (raw)
In-Reply-To: <athuYJjPMkrecGm3@inochi.infowork>
On Wed, Oct 21, 2026 at 03:51:20PM +0800, Inochi Amaoto wrote:
> On Mon, Oct 19, 2026 at 11:41:08AM -0500, Bjorn Helgaas wrote:
> > On Tue, Sep 29, 2026 at 04:37:47PM +0800, Inochi Amaoto wrote:
...
> > > +struct k1_pcie_device_data {
> > > + const struct dw_pcie_host_ops *host_ops;
> > > + const struct dw_pcie_ops *ops;
> > > + int (*parse_port)(struct k1_pcie *k1);
> > > +};
> >
> > Does the "const" here add anything useful? This patch suggests maybe
> > not:
> >
> > https://lore.kernel.org/all/20260911233541.1650895-2-james.quinlan@broadcom.com/
>
> I am not sure whether the compiler can make use it.
> And I have not seen any explaination for why no reason
> for that. It is good to have a clarification.
These const make no sense. First of all, the third one is missing it.
And I have no idea what would be the proper syntax to add a such. But
adding a such make it clear that there no sense to have them. Either
you make the const the whole data type instance on the user level or
don't do it at all.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-21 9:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 8:37 [PATCH v7 0/6] riscv: spacemit: Add PCIe RC controller support for K3 Inochi Amaoto
2026-09-29 8:37 ` [PATCH v7 1/6] PCI: spacemit-k1: Add device data support Inochi Amaoto
2026-09-30 7:55 ` Andy Shevchenko
2026-10-19 16:41 ` Bjorn Helgaas
2026-10-21 7:51 ` Inochi Amaoto
2026-10-21 9:12 ` Andy Shevchenko [this message]
2026-09-29 8:37 ` [PATCH v7 2/6] PCI: spacemit-k1: Add multiple PHY handles support Inochi Amaoto
2026-09-30 7:57 ` Andy Shevchenko
2026-09-29 8:37 ` [PATCH v7 3/6] PCI: spacemit-k1: Add device id update helper Inochi Amaoto
2026-09-30 7:58 ` Andy Shevchenko
2026-09-29 8:37 ` [PATCH v7 4/6] dt-bindings: PCI: snps,dw-pcie: Add msi-parent for MSI handle check Inochi Amaoto
2026-09-29 8:37 ` [PATCH v7 5/6] dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller Inochi Amaoto
2026-10-06 15:50 ` Rob Herring (Arm)
2026-09-29 8:37 ` [PATCH v7 6/6] PCI: spacemit-k1: Add Spacemit K3 PCIe host controller support Inochi Amaoto
2026-09-30 7:54 ` Andy Shevchenko
2026-09-30 9:44 ` Inochi Amaoto
2026-10-18 12:15 ` Manivannan Sadhasivam
2026-10-18 12:35 ` Manivannan Sadhasivam
2026-10-21 7:56 ` Inochi Amaoto
2026-10-21 8:26 ` Siddharth Vadapalli
2026-09-29 17:00 ` [PATCH v7 0/6] riscv: spacemit: Add PCIe RC controller support for K3 Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atiB7-u5bxJbf-1q@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=Frank.Li@nxp.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=asrinivasan@oss.tenstorrent.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=christian.bruel@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=dlan@kernel.org \
--cc=elder@riscstar.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=helgaas@kernel.org \
--cc=inochiama@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=looong.bin@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=palmer@dabbelt.com \
--cc=pengpeng@iscas.ac.cn \
--cc=pjw@kernel.org \
--cc=randolph@andestech.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=spacemit@lists.linux.dev \
--cc=u.kleine-koenig@baylibre.com \
--cc=vidyas@nvidia.com \
--cc=vincent.guittot@linaro.org \
--cc=zhangsenchuan@eswincomputing.com \
--cc=zhangxincheng@ultrarisc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®