From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Hans de Goede <hansg@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linusw@kernel.org>,
linux-input@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Input: soc_button_array - use __free() cleanup facilities to free memory
Date: Wed, 21 Oct 2026 10:53:06 -0700 [thread overview]
Message-ID: <atj71VUZdpHO4aBT@google.com> (raw)
In-Reply-To: <atj5pgIU0VCcrHHX@ashevche-desk.local>
On Wed, Oct 21, 2026 at 08:43:02PM +0300, Andy Shevchenko wrote:
> On Wed, Oct 21, 2026 at 10:15:43AM -0700, Dmitry Torokhov wrote:
> > On Wed, Oct 21, 2026 at 08:05:37PM +0300, Andy Shevchenko wrote:
> > > On Tue, Oct 20, 2026 at 06:50:00PM -0700, Dmitry Torokhov wrote:
>
> ...
>
> > > > + const union acpi_object *desc __free(kfree) = buf.pointer;
> > >
> > > Rafael added 'acpi_object_free' for __free() (pun wasn't intended :-).
> >
> > Not sure why it is better... It goes through ACPI_FREE() ->
> > acpi_os_free() wrappers which might be nice for ACPICA code, but has
> > limited utility in the rest of the kernel code...
>
> Today it might be similar, tomorrow it might be different. ACPI objects should
> be freed with their proper APIs at least for the sake of consistency, no?
Fair enough. I'll add a todo to switch once it hits mainline.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-10-21 17:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 1:49 [PATCH 1/3] Input: soc_button_array - use resources to set up IRQ info for gpio-keys Dmitry Torokhov
2026-10-21 1:50 ` [PATCH 2/3] Input: soc_button_array - use __free() cleanup facilities to free memory Dmitry Torokhov
2026-10-21 10:06 ` Bartosz Golaszewski
2026-10-21 17:05 ` Andy Shevchenko
2026-10-21 17:15 ` Dmitry Torokhov
2026-10-21 17:43 ` Andy Shevchenko
2026-10-21 17:53 ` Dmitry Torokhov [this message]
2026-10-21 18:21 ` Andy Shevchenko
2026-10-21 1:50 ` [PATCH 3/3] Input: soc_button_array - convert to software nodes Dmitry Torokhov
2026-10-21 10:11 ` Bartosz Golaszewski
2026-10-21 16:56 ` Dmitry Torokhov
2026-10-21 17:02 ` Arnd Bergmann
2026-10-21 17:16 ` Dmitry Torokhov
2026-10-21 17:13 ` Andy Shevchenko
2026-10-21 17:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atj71VUZdpHO4aBT@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=arnd@arndb.de \
--cc=brgl@kernel.org \
--cc=hansg@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®