From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.11 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792591170; b=pZJLQkwJct3nOjVSRxVEd/mTIaSHrTDwWVYQ5YHNYYiE5KSd7iSrnspJyazueUP0IRbE mSChyDglccj5aJ8YBrW4hWwUQcIZhSvIPXkQUS+C8Fn72IwY7/DURZv00oWm4H/oLWynt 9wD/kOkhp6IZdjd5lf02t/mBQXxbz1WCOUDDqBf8xt5eJ0jxCA41AHlENrslxoZ8A8zQL A99rpe9W1yrNjYIrWUjCrumR+V96WEIGowgO/UGO+1dfRd+pSc6uL7p/qYKFSH+rAP1p4 xX6HS1JlLouOIBASdHYqc+juTpD1jBPnZOWRA15F7Oj1NU3W29Kv7BoeMmK8PQnbDaQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792591170; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=UE2jAlTYEq+YwHW+pSln9hYyMLJjzucBmaYDCqdkEk0=; b=E6RyQD6wrWjDNSwC3+1zlF+utTDBl0nLQpKfO4EMsJLSUxN5dwTGuj991L1sYltsmwte iwdogt7sqvPuSqixfrxfGzhm5i1HcYPgltUuzlLLGro6vPit7+yUNnBmMuCjtMDB7fa/O nP98a62G3w1H6tdkOGrN1QQq9yfRnhezRJ+wvQg3rKyxNyGcba4mWaqYgFKBcr6TEa7/j o1vN24Mpi2xvP0VL/OL3yYfKfVVn1lg2+hw0pF/P4P3tRwXhmxp2JtoYo9QF6xrMtmFev mZ0tEy/4kXfwkDcUyoACNoWIp12j2Ebfm8Fm61zUeerukmRr0CJxzb5n9WSdPSTB9Jg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OCvV4YYK; arc=none smtp.remote-ip=198.175.65.11 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAEE0606A338 for ; Wed, 21 Oct 2026 13:59:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org CAEE0606A338 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OCvV4YYK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1792591170; x=1824127170; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=M9ma1PfVa4eoTZ1+X/BoZc4yKj+bFJpViB/TmVSBVto=; b=OCvV4YYKGzpE6dAESTmOcVIBAfSlCVeu2NmyJ04H7prPLIRixDVTFUL5 mdkvV83+PvG0cwjVhQk14zvIpgQdn8Qj4DmHrl8AoGd5z43X3vPfBT3+C AEEtwoeDIXmY9iAvmMKyskYAXuNygNwoU6Xi/32/V+f3pjqUVLF7ttb8w 2HT6vUeK3QgEWwoNaZo09kQ1Q84lZ26KfeWojY5ULJKF382j3k19qkRpj FhslqCB6kJ7+DD8YYQJhCaBHPMaDIkeNP3XCGWliqcZdx++XT3cqsf/l5 rO/ftA6Y0c9q5sy5N48eq9/dGEqNGd7C0EUvpegWGp9Nq/o8OnBN4FvhP Q==; X-CSE-ConnectionGUID: Umw+dNlOQhmj4ONQMRdi3g== X-CSE-MsgGUID: VyZxkF7AS7CrDgTRrcCfBw== X-IronPort-AV: E=McAfee;i="6800,10657,11942"; a="1203627" X-IronPort-AV: E=Sophos;i="6.27,170,1787036400"; d="scan'208";a="1203627" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2026 06:59:03 -0700 X-CSE-ConnectionGUID: 48h6JtW3QuWQOPaAujilUw== X-CSE-MsgGUID: 5isEUzeEQj6JXLOxkkNt2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,170,1787036400"; d="scan'208";a="3155684" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.24]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2026 06:59:01 -0700 Date: Wed, 21 Oct 2026 16:58:59 +0300 From: Andy Shevchenko To: Lee Jones Cc: Binbin Zhou , Chong Qiao , mfd@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/28] mfd: ls2kbmc: Allocate simplefb platform_data on the heap Message-ID: References: <20261021121245.3111563-1-lee@kernel.org> <20261021121245.3111563-4-lee@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261021121245.3111563-4-lee@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Oct 21, 2026 at 12:09:26PM +0000, Lee Jones wrote: > ls2k_bmc_probe() declares struct simplefb_platform_data on the stack and > assigns its address to the display MFD cell. Although mfd_add_device() > deep-copies platform_data via platform_device_add_data() before > ls2k_bmc_probe() returns, the shallow mfd_cell copy attached to the > child platform device retains a stale pointer to the expired stack > frame. > > Allocate the simplefb_platform_data structure on the heap via > devm_kzalloc() prior to devm_mfd_add_devices() so the pointer remains > valid for the lifetime of the child platform device. Reviewed-by: Andy Shevchenko assuming you will add Reported-by: Sashiko... -- With Best Regards, Andy Shevchenko