From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.44 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792599277; b=oRiqO2xXPrdliijO968EIFsGzf9jywFoqGim2pRfE9BchUUwvBDQ1FIOW47azxW6ZLBF aZwh4cZblgorQGMNrFj43ciTEVmOQcm68CfSMjLtXi2KSr+Q4o8CRDD6hPP+NlITmk8en cdSHNFzmOvQx3iQS47WGn05RuaWJS2iIGLFd9JgJAEnOcDzp9yBfvBDyVwBEMV9lmIRZo G+tmH6Rz35uyqcK0RGMLZCbbygMHqpTZQ5rp7gM1JAH7lgMzxw2QZbg3Uh1ZMheJ/NR8o NuZyco5MOBbcleAMUOdxD5lw4B+iP4INsDG0FC5CuWTwqJWhu74CPsgeD3ujhFbZ2Jg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792599277; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=EYfi7okTi0CauQZlFNuFbrUJBFVpuaI/7/o4adTAMHk=; b=Jq9+IBgspx8FTV7LJ1pQezvzjdm6NCVJyXx/XmzdkxHcQsI10oJPXkWbukc2JkrgEZWP GplkN2+KRnbGIaF0GTq6+oLA49Bd+YcyfyPKTeuAWW7qT1f9jo783SytbrCwEEUM4Z0pW P2Et9hGguodv3MXUTPsoflbef5EmN8dO29pV+TadnSM91e5YAg0dfHrDwIMQ9iYfCgZd+ 7AadtXJKJpWFYqwyTifVdlw+WDdXD/hkl7dRNDleMzwY+H/MZegSIXpCHsepqz9LY4IYg yzKW/xLNYMulhZK9kczMAc86DWiWp5rh8wcHfuStcntAIEwS5/jd51i2YXRkwFiI9iQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; arc=none smtp.remote-ip=209.85.221.44 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26BA4606A578 for ; Wed, 21 Oct 2026 16:14:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 26BA4606A578 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-48df8fe8513so884408f8f.0 for ; Wed, 21 Oct 2026 09:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1792599264; x=1793204064; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=EYfi7okTi0CauQZlFNuFbrUJBFVpuaI/7/o4adTAMHk=; b=YCvufwYMMCbR6JgJ7YV8qJiqV9S9KJVzrgAdjuqJJRWbg1Y31t8jMfajRYqEpvfdlc ACuyzdCAY65Mi7chBCIqIZEezxMU6H7bdQXFJ54h6WxVNQH7Exhz12cuQaK9Bs1TyK9Y un3TXpt14Wd+S+LOv7k0HrFzvDr4MmODYzBTky2uEGUvzSGcnxvD2jOfcdkvn7rD40m3 IENOmr/NVpSqgPeCf8w0px+hCvFR3CGqZIo1qVCglnfVbWE06Sv3gce11o//6VMpRz2C ywHkVfiwIlPXiFQMbRMbwuIcpzmdF401Ys3BkVF1O4ZzU/7RRKQX+iCsXZ8avL9XOA3w oLJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792599264; x=1793204064; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EYfi7okTi0CauQZlFNuFbrUJBFVpuaI/7/o4adTAMHk=; b=po6Fmn5CXcwDQW+m/F7QNtKhsicLiOZfi/BehIkbAhvDcMKo5p2f3VHimf2GXFVnhG pxa2NTHkX5yWGeaRAJLuCctqKUw/GnZp6jziQVODGnfDdPz4+dWmoly55tUOGYoGFPNh SRA2glOd+Ri+3HuqqvfMS8qkYx7L/oRd7DhPfaAPp0KnHXplFsQKpAEBE5UgF2OMjDj5 aazXs7cvHD25VeoCaH+0uJpq1vASdvoK8tZXMKxXniACeMVjeOkKCR2hBgYlcP8HLSp0 2AsjVYvZkijBE4BlmOydm38lpge0yDEgRzsgjS7JWTKlZBVlS6LfG66kNLMRvKyNva1Y K27w== X-Forwarded-Encrypted: i=1; AKwUvBxA0s5hxjvr4SZxHwvOCOiGT6PIDI9DSRdST3GhzflF4brJ66sP79tX2hBlkVcS96AR2ieV7O1lFJZglHw=@vger.kernel.org X-Gm-Message-State: AFq9FYKesbyzFYtb7Fpjc6lDiX9mIzYIBdqLvF6FThpCu/msCXoLZhC+ qHVeVQLFtX+b7NT9iWtgYMvSGnolpckVLfnkSAJFIcPJVzYk1r6sI93ZorfjJsFt4U8= X-Gm-Gg: AYBFou2/sJGMs+NkZSskEHnbESCDj/OOOMYs2Nag///mURuj1kouA5p/0uZnXRfo5sG sxiSRLHJH/qHg22+p96c6KvZ/5lVMXN1GabhcnWyjFMdymBNpxqMRT+FabGTb7CZ34o7j91+03b 8r0aNw/gZO7hV/WV5Fru96zDvyebwLwHypUZS3J5gwBYfCdN5mJQXtKztkGysMsHyaJQArg8ac9 sAPc6Cy/tqCaGtDkNb+n7XVf9irTu3Yo444ldgESS2GRkk3LZlpEf5egD3mEICBn9PEt/gw2q/L ZfF6taeHgSVnGsrzr+UEgaP8jX0POpagsQTRsIzPctKvJ/p+5HiUBfPTW/xaRcychUdxCw9qs0C g5FnrKYglmrLQtczjj7I9lrRPovhQqJJvostg/5PuHu1Pi726Vb+vYK9ngkEVi+tmqo4OdYVs9k FF6d/lGwNMSHU50fR5AyOonliwA7lKUeCALmQT8ekmzFeXGadsqDAfK0P6EGwHpglO3p4mDr12G +nO8sGsyXjA1DV9OGLlOpFIeHBm6Mh7M8cpHI68zjXzOzFJ31m0A8aK6IBdtO29hbD308NiNlHI PaaWnMDCTmjLMnhWpSM+Xb++zuXW0bei4KJtmZGa2TA= X-Received: by 2002:a05:6000:2dc9:b0:48d:fbdd:4132 with SMTP id ffacd0b85a97d-48e264a6345mr5617302f8f.18.1792599264403; Wed, 21 Oct 2026 09:14:24 -0700 (PDT) Received: from localhost (p200300f65f19a904634661a51962f5e0.dip0.t-ipconnect.de. [2003:f6:5f19:a904:6346:61a5:1962:f5e0]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-48e25841fe4sm6698401f8f.53.2026.10.21.09.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2026 09:14:23 -0700 (PDT) Date: Wed, 21 Oct 2026 18:14:22 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: "lianfeng.ouyang" Cc: Olivia Mackall , Herbert Xu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 2/2] hwrng: starfive: rework clk/reset teardown order for JHB100 Message-ID: References: <20261021083712.3032-1-lianfeng.ouyang@starfivetech.com> <20261021083712.3032-3-lianfeng.ouyang@starfivetech.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n5t7utkqknwcdicr" Content-Disposition: inline In-Reply-To: <20261021083712.3032-3-lianfeng.ouyang@starfivetech.com> --n5t7utkqknwcdicr Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v9 2/2] hwrng: starfive: rework clk/reset teardown order for JHB100 MIME-Version: 1.0 On Wed, Oct 21, 2026 at 04:37:12PM +0800, lianfeng.ouyang wrote: > From: Lianfeng Ouyang >=20 > Rework the StarFive TRNG driver to address hardware-specific requirements > for JHB100 SoC. To avoid reset-domain crossing glitches, the driver now > ensures clocks are gated before asserting reset during teardown for > JHB100, while JH7110 retains the original reset-first sequence. >=20 > Add per-compatible match data (struct starfive_trng_data) describing the > clock/reset teardown order, a new "starfive,jhb100-trng" compatible, and > select the ordering from it. >=20 > Fix the runtime-PM get/put balancing across the init/read/reseed/cleanup > paths, manage PM and the clk/reset teardown via devm so all error paths > unwind correctly, run the SEU-triggered reseed from a workqueue instead > of hard IRQ, and serialise the command sequences with a mutex. This sounds like three commits, with at least the third getting a Fixes: line. =20 > +#include > #include > #include > -#include > +#include > +#include > +#include > #include > +#include > #include > #include > #include > #include > -#include > +#include > +#include > +#include > +#include Please don't add . already provides of_device_id, so just dropping should work fine. > #include > -#include > +#include > #include > #include > -#include > +#include > #include > +#include > +#include All that header rearrangement is worth pointing out in the commit log. Best regards Uwe --n5t7utkqknwcdicr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmrY5NsACgkQj4D7WH0S /k67hAgAkskrK7Zfzy1Ye0Z3TqK6UQV0vrDBR6LB4bRpA7K5fC2zxEHV3jjN6CwO +k+1d2C/DKYEQ8arf67BX3wqGKW6KjqqSfbEbUM9trV0jIZwLPAHlyDSGxiVPKDn z28jyuNDMjmVJfTZXUyD0/JRnyLo20evi9pEFGI0OB80CLwg3nWf+g0hnIVaJg0b n2HZO8PF42OzET7+9gVski9Rh3qdq0kEBZgVDAe57ybfSKFM7pFDelzMwXYKxX65 zfSYB1qImYb0Y8oe3TA3mDYTdWXrh56+fLIWUAMAkBIfVu34qf8WfAdIuCcmcd40 lm14jNAcwCHd0U308PYpap0aWDIFjw== =S1vP -----END PGP SIGNATURE----- --n5t7utkqknwcdicr--