mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf build: Add MINIMAL=1 to build without optional features
Date: Wed, 21 Oct 2026 22:40:18 -0300	[thread overview]
Message-ID: <atlpgvF_WELAFSuD@x2> (raw)
In-Reply-To: <atlICVt3ItifkPZb@google.com>

On Wed, Oct 21, 2026 at 04:17:29PM -0700, Namhyung Kim wrote:
> On Sun, Oct 18, 2026 at 09:53:21AM -0400, Sasha Levin wrote:
> > Turning off every optional feature takes a long list of NO_* variables,
> > and the list has to follow features as they are added and renamed. The
> > one in tests/make for make_minimal has fallen behind: it leaves
> > libtraceevent, jevents, slang, AIO, LZMA, zlib, libLLVM and Rust to be
> > detected, so a make_minimal build still needs libtraceevent and python.
> > 
> > Add MINIMAL=1, which turns off every optional feature, the BPF
> > skeletons, and the shellcheck, mypy and pylint runs. perf then builds,
> > natively or cross, with no library beyond the C library and without
> > python, pkg-config, clang or rustc, and the result does not depend on
> > what is installed on the build machine.
> > 
> > A MINIMAL=1 build also leaves out the notices that post unwind and
> > python support are disabled, which it asked for, and the one about the
> > pkg-config search path for cross builds, as pkg-config is not needed
> > then.
> > 
> > It is handled in Makefile.perf rather than Makefile.config, as
> > Makefile.config is included after the pkg-config, shellcheck, mypy and
> > pylint setup.
> > 
> > Use it for make_minimal in tests/make.
> > 
> > Suggested-by: Ian Rogers <irogers@google.com>
> > Link: https://lore.kernel.org/r/CAP-5=fWFY-tpJz2vcBZvurwdZY5gwd8cuTemE9q1rtZ0Vi0dng@mail.gmail.com
> > Assisted-by: LLM
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Not tested but:

Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

- Arnaldo

      reply	other threads:[~2026-10-22  1:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18 13:53 Sasha Levin
2026-10-21 23:17 ` Namhyung Kim
2026-10-22  1:40   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atlpgvF_WELAFSuD@x2 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®