From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Jeremy Dean Clifton <deaner92@yahoo.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] dt-bindings: pwm: Convert NXP PCA9685 PWM controller to DT schema
Date: Thu, 22 Oct 2026 09:53:01 +0200 [thread overview]
Message-ID: <atnAaDo0fy7Az_eg@monoceros> (raw)
In-Reply-To: <20261022000029.125691-1-deaner92@yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
Hello Jeremy,
On Thu, Oct 22, 2026 at 12:00:28AM +0000, Jeremy Dean Clifton wrote:
> Convert the NXP PCA9685 PWM controller binding to DT schema format.
>
> Changes from the text binding:
>
> Document the 'reg' property and make it required. It was missing
> from the text binding, although the example used it and the device
> cannot work without the I2C address.
>
> Rename the example node to the generic 'pwm', as required by
> pwm.yaml.
>
> Describe both cells of the PWM specifier, and state that 'invert'
> and 'open-drain' apply to all outputs, as per the datasheet (INVRT
> and OUTDRV bits in MODE2).
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Jeremy Dean Clifton <deaner92@yahoo.com>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-nexxt
as 7.5 material.
> + "#pwm-cells":
> + const: 2
> + description:
> + The first cell is the PWM channel index, from 0 to 15, or 16 for the
> + ALLCALL channel, which sets all PWM channels at the same time. The
> + second cell is the PWM period in nanoseconds.
If you want to work on that binding, you can deprecate #pwm-cells = <2>
and make <3> the right value.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-10-22 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261022000029.125691-1-deaner92.ref@yahoo.com>
2026-10-22 0:00 ` Jeremy Dean Clifton
2026-10-22 7:53 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atnAaDo0fy7Az_eg@monoceros \
--to=ukleinek@kernel.org \
--cc=conor+dt@kernel.org \
--cc=deaner92@yahoo.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®