From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Xueyuan Chen <xueyuan.chen21@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Peter Xu <peterx@redhat.com>,
"David Hildenbrand (Arm)" <david@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
shaos <shawnq1@163.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/vma: avoid broken uffd merge on mremap
Date: Thu, 22 Oct 2026 11:15:58 +0100 [thread overview]
Message-ID: <atniL5lYyE28HSTm@gremlin> (raw)
In-Reply-To: <179266301162.763593.1501773594946042790.b4-review@b4>
On Thu, Oct 22, 2026 at 05:56:51PM +0800, Xueyuan Chen wrote:
> > diff --git a/tools/testing/vma/include/stubs.h b/tools/testing/vma/include/stubs.h
> > index be8f5161f92a..f786a585caf0 100644
> > --- a/tools/testing/vma/include/stubs.h
> > +++ b/tools/testing/vma/include/stubs.h
> > +static inline bool vma_has_uffd_without_event_remap(struct vm_area_struct *vma)
> > +{
> > + return false;
> > +}
> > +
>
> Would it make sense to have the stub in tools/testing/vma/include/stubs.h
> return a configurable bool, e.g. uffd_without_event_remap, and add a test
> for the true case? The existing tests would continue to cover the false case.
No, stubs.h are for simple stubs.
Changes like that would be only be made if needed.
>
> Reviewed-by: Xueyuan Chen <xueyuan.chen21@gmail.com>
Thanks!
--
Cheers, Lorenzo
next prev parent reply other threads:[~2026-10-22 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 14:55 Lorenzo Stoakes (ARM)
2026-10-20 15:51 ` David Hildenbrand (Arm)
2026-10-20 17:03 ` Kiryl Shutsemau
2026-10-20 17:24 ` Lorenzo Stoakes (ARM)
2026-10-20 17:27 ` Gregory Price (Meta)
2026-10-22 9:56 ` Xueyuan Chen
2026-10-22 10:15 ` Lorenzo Stoakes (ARM) [this message]
2026-10-22 11:23 ` Xueyuan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atniL5lYyE28HSTm@gremlin \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=jannh@google.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=pfalcato@suse.de \
--cc=rppt@linux.vnet.ibm.com \
--cc=shawnq1@163.com \
--cc=stable@vger.kernel.org \
--cc=vbabka@kernel.org \
--cc=xueyuan.chen21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®