From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Frank Li <Frank.li@oss.nxp.com>
Cc: "Arnav Kapoor" <kapoorarnav43@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
linux-iio@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: fsl-imx25-gcq: check the return value of the
Date: Thu, 22 Oct 2026 19:37:18 +0300 [thread overview]
Message-ID: <ato7vgweOlpMA9eE@ashevche-desk.local> (raw)
In-Reply-To: <atoyD5GpW-4uWKjq@SMW015318>
On Thu, Oct 22, 2026 at 10:55:59AM -0500, Frank Li wrote:
> On Thu, Oct 22, 2026 at 04:24:45AM +0530, Arnav Kapoor wrote:
> > The driver ignores the return value of all the regmap accesses. If one
> > of them fails, e.g. because the memory mapped registers can't be
> > accessed, the driver just continues with an undefined state.
>
> MMIO never return failure. if write register fail at irq, it will cause
> irq storm.
Strictly speaking it may lead to some CPU exceptions in some cases, but that's
different level of failures and not related to the error codes from regmap IO
accessors.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-22 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 22:54 Arnav Kapoor
2026-10-22 15:55 ` Frank Li
2026-10-22 16:37 ` Andy Shevchenko [this message]
2026-10-22 16:35 ` Andy Shevchenko
2026-10-22 16:44 ` Arnav Kapoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ato7vgweOlpMA9eE@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.li@oss.nxp.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jic23@kernel.org \
--cc=kapoorarnav43@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®