From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Bamvor Jian Zhang <bamv2005@gmail.com>,
Linus Walleij <linusw@kernel.org>,
Samuel Moelius <sam.moelius@trailofbits.com>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/3] gpio: Introduce helper to dispose IRQ mappings
Date: Thu, 22 Oct 2026 16:32:44 +0300 [thread overview]
Message-ID: <atoQfGQZeJDU3eMF@ashevche-desk.local> (raw)
In-Reply-To: <CAMRc=MdHEzHBXx=P1-0Ut80P5=sQnPDwZRD-zdpoE75iHcJjBA@mail.gmail.com>
On Thu, Oct 22, 2026 at 02:11:38AM -0700, Bartosz Golaszewski wrote:
> On Wed, 21 Oct 2026 22:44:42 +0200, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> said:
> > I have noticed that a few drivers use almost the same code to dispose IRQ
> > mappings. This series to deduplicate the efforts. I only converted a couple
> > of the users (there are potentially more) in order to stay in the same
> > subsystem.
> The "few" being 2 testing drivers of which one (mockup) should ideally go away.
> Do we really want to add more code to GPIO core that will only be used in
> testing module(s)? I don't think this is useful, sorry.
I meant a few. As I pointed these were chosen explicitly for the sake of not
crossing the subsystem boundaries. I looked at Broadcom one, it is so big mess
but I think I can get an advantage on it. Also there are other drivers that
just need more work to check (and many of them are outside of drivers/gpio),
but I'm pretty sure the new API has a good potential.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-22 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 20:44 Andy Shevchenko
2026-10-21 20:44 ` [PATCH v1 1/3] gpiolib: Introduce devm_gpiochip_dispose_irq_mappings() Andy Shevchenko
2026-10-21 20:44 ` [PATCH v1 2/3] gpio: mockup: Replace custom devm_gpiochip_dispose_irq_mappings() Andy Shevchenko
2026-10-21 20:44 ` [PATCH v1 3/3] gpio: sim: " Andy Shevchenko
2026-10-22 9:11 ` [PATCH v1 0/3] gpio: Introduce helper to dispose IRQ mappings Bartosz Golaszewski
2026-10-22 13:32 ` Andy Shevchenko [this message]
2026-10-22 14:05 ` Bartosz Golaszewski
2026-10-22 14:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atoQfGQZeJDU3eMF@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=bamv2005@gmail.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam.moelius@trailofbits.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®