From: Jarkko Sakkinen <jarkko@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>
Subject: Re: [RFC PATCH 5/6] KEYS: Replace assoc_array with struct keyring_index
Date: Fri, 23 Oct 2026 01:10:20 +0300 [thread overview]
Message-ID: <atqJzKw12w0MFOwQ@kernel.org> (raw)
In-Reply-To: <20261018070822.GA1904@sol>
On Sun, Oct 18, 2026 at 12:08:22AM -0700, Eric Biggers wrote:
> Make 'hash' u32 and make it adjacent to 'is_keyring' to get rid of the
> hole?
The whole 'is_keyring' is completely redundant and more like a glitch
in this RFC patch (equal to key->type == &key_type_keyring).
Nothing wrong in the review comment. I just wanted to remark this
dead obvious fact that I should noticed immediately (doing updates
ATM) :-)
Br, Jarkko
next prev parent reply other threads:[~2026-10-22 22:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 21:52 [RFC PATCH 0/6] KEYS: From assoc_array to rhashtable migration Jarkko Sakkinen
2026-10-16 21:52 ` [RFC PATCH 1/6] keys: prevent quota overflow and widen quotalen and datalen to 32 bits Jarkko Sakkinen
2026-10-17 5:28 ` Eric Biggers
2026-10-17 16:48 ` Jarkko Sakkinen
2026-10-16 21:53 ` [RFC PATCH 2/6] keys: reclaim link quota during keyring garbage collection Jarkko Sakkinen
2026-10-17 5:42 ` Eric Biggers
2026-10-17 17:06 ` Jarkko Sakkinen
2026-10-16 21:53 ` [RFC PATCH 3/6] keys: verify key identity on unlink and move Jarkko Sakkinen
2026-10-16 21:53 ` [RFC PATCH 4/6] keys: Add keyring_is_empty() for {fs,dm}-verity Jarkko Sakkinen
2026-10-16 21:53 ` [RFC PATCH 5/6] KEYS: Replace assoc_array with struct keyring_index Jarkko Sakkinen
2026-10-16 22:27 ` Jarkko Sakkinen
2026-10-18 7:08 ` Eric Biggers
2026-10-18 15:09 ` Jarkko Sakkinen
2026-10-18 15:12 ` Jarkko Sakkinen
2026-10-22 22:10 ` Jarkko Sakkinen [this message]
2026-10-21 23:22 ` Jarkko Sakkinen
2026-10-22 14:11 ` Jarkko Sakkinen
2026-10-16 21:53 ` [RFC PATCH 6/6] lib: Remove unused assoc_array Jarkko Sakkinen
2026-10-19 15:02 ` [RFC PATCH 5/6] KEYS: Replace assoc_array with struct keyring_index David Howells
2026-10-19 15:27 ` Jarkko Sakkinen
2026-10-22 15:56 ` Jarkko Sakkinen
2026-10-19 21:46 ` [RFC PATCH 6/6] lib: Remove unused assoc_array David Howells
2026-10-19 21:50 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atqJzKw12w0MFOwQ@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®