From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Peter Chen <peter.chen@oss.qualcomm.com>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Wesley Cheng <wesley.cheng@oss.qualcomm.com>,
"fabricioakio@gmail.com" <fabricioakio@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Subject: Re: [PATCH] usb: dwc3: qcom: Check for L2 only when suspending a host with wakeup
Date: Thu, 22 Oct 2026 23:44:25 +0000 [thread overview]
Message-ID: <atqdCfSLOD_g66i4@vbox> (raw)
In-Reply-To: <atmChJYMtjPtW_ZE@hu-petche-lv.qualcomm.com>
On Wed, Oct 21, 2026, Peter Chen wrote:
> On 26-10-21 15:44:52, Konrad Dybcio wrote:
> > On 9/28/26 8:16 PM, Fabricio Akio via B4 Relay wrote:
> > > From: Fabricio Akio <fabricioakio@gmail.com>
> > >
> > > In peripheral mode the core disconnects and powers the PHY off before
> > > the glue suspends, so the link never enters L2 and every system
> > > suspend logs "HS-PHY not in L2". Check only for a host with wakeup,
> > > the one case that parks the PHY in L2.
> > >
> > > Signed-off-by: Fabricio Akio <fabricioakio@gmail.com>
> > > ---
> >
> > I think we should be able to retain the link in L2 in device
> > mode too upon suspend, but that needs more plumbing on the
> > clock/gdsc side? (+Cc)
> >
>
> From what I see, dwc3 core just keeps gadget (device mode) disconnecting
> when dwc3 core enters suspend. The reason is probably dwc3 core wakeup signal
> (through .dwc3_gadget_wakeup or dwc3_gadget_func_wakeup) is send by software.
> When the system has suspended, no software has run, so can't trigger wakeup.
Remote wakeup isn't the limitation. The host decides when to put the
link to L2/U3, and the device must still respond to a host resume or
reset while suspended. If the core is powered down and its state is
lost, it can't do that. To support this, we'd need to implement device
hibernation.
>
> For runtime suspend, current dwc3 core doesn't consider link suspend event
> (eg, L2/U3) as low power event, and doesn't put dwc3 core entering runtime
> suspend, so the link is always L2 or U3.
>
Right, dwc3 won't runtime suspend while connected, regardless of the
link state.
Fabricio's patch is fine as is.
Thanks,
Thinh
prev parent reply other threads:[~2026-10-22 23:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 18:16 Fabricio Akio via B4 Relay
2026-09-29 17:16 ` Huang Wei
2026-10-02 23:55 ` Thinh Nguyen
2026-10-04 9:31 ` Joonhoe Kim
2026-10-04 9:34 ` Joonhoe Kim
2026-10-05 9:58 ` Pankaj Patil
2026-10-21 13:44 ` Konrad Dybcio
2026-10-22 3:27 ` Peter Chen
2026-10-22 23:44 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atqdCfSLOD_g66i4@vbox \
--to=thinh.nguyen@synopsys.com \
--cc=fabricioakio@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@oss.qualcomm.com \
--cc=wesley.cheng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®