From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: wim@linux-watchdog.org, linux@roeck-us.net,
p.zabel@pengutronix.de, Sergey.Semin@baikalelectronics.ru,
mika.westerberg@linux.intel.com, andi.shyti@kernel.org,
iav@iav.lv, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] watchdog: dw_wdt: clean up error paths in resume function
Date: Fri, 23 Oct 2026 03:06:04 +0000 [thread overview]
Message-ID: <atrPHJmmPBHuvbDx@google.com> (raw)
In-Reply-To: <20261022134354.534642-4-a.shimko.dev@gmail.com>
On Thu, Oct 22, 2026 at 04:43:51PM +0300, Artem Shimko wrote:
> Clean up of dw_wdt_resume() function.
>
> Rework the error handling to use properly named labels that match the
> cleanup order. Use unprepare_clk for clock disable and unprepare_pclk
> for pclk disable path.
>
> Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
See [PATCH v2 2/3]. I'd suggest squashing this patch into [v2 2/3].
> @@ -393,16 +393,15 @@ static int dw_wdt_suspend(struct device *dev)
> static int dw_wdt_resume(struct device *dev)
> {
> struct dw_wdt *dw_wdt = dev_get_drvdata(dev);
> - int err = clk_prepare_enable(dw_wdt->clk);
> + int err;
>
> + err = clk_prepare_enable(dw_wdt->clk);
This is an additional change, but I think it's fine to squash.
next prev parent reply other threads:[~2026-10-23 3:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 13:43 [PATCH v2 0/3] watchdog: dw_wdt: fix reset line management Artem Shimko
2026-10-22 13:43 ` [PATCH v2 1/3] watchdog: dw_wdt: use devm_reset_control_get_optional_shared_deasserted Artem Shimko
2026-10-23 3:05 ` Tzung-Bi Shih
2026-10-22 13:43 ` [PATCH v2 2/3] watchdog: dw_wdt: manage reset line during system suspend/resume Artem Shimko
2026-10-23 3:05 ` Tzung-Bi Shih
2026-10-22 13:43 ` [PATCH v2 3/3] watchdog: dw_wdt: clean up error paths in resume function Artem Shimko
2026-10-23 3:06 ` Tzung-Bi Shih [this message]
2026-10-22 21:15 ` [PATCH v2 0/3] watchdog: dw_wdt: fix reset line management Igor Velkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atrPHJmmPBHuvbDx@google.com \
--to=tzungbi@kernel.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=a.shimko.dev@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=iav@iav.lv \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mika.westerberg@linux.intel.com \
--cc=p.zabel@pengutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®