mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hangbin Liu <hangbin.liu@linux.dev>
To: Xia Yan <yana06070@163.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, horms@kernel.org,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, pabeni@redhat.com,
	shuah@kernel.org
Subject: Re: [PATCH net v3 2/2] selftests: net: check veth carrier after changing channel counts
Date: Fri, 23 Oct 2026 11:15:15 +0800	[thread overview]
Message-ID: <atrRQzn2prYbF1vF@fedora> (raw)
In-Reply-To: <20261023023350.7225-1-yana06070@163.com>

On Fri, Oct 23, 2026 at 10:33:50AM +0800, Xia Yan wrote:
> Hi Hangbin,
> 
> Thanks for reproducing the issue and reviewing the driver fix.
> 
> > Why do you do gro setting in rx/tx set ups?
> 
> I included GRO off/on to cover both queue reconfiguration paths.
> No XDP program is attached in these cases. With GRO on,
> veth_enable_range_safe() and veth_disable_range_safe() set up or tear
> down per-RX-queue NAPI instances as the RX queue count changes. With
> GRO off, those helpers do not need to reconfigure NAPI.
> 
> The carrier bug reproduces in both configurations, so the test checks
> the same carrier state with and without the NAPI resource changes.

I mean this doesn't seem related to the carrier on/off (LOWER_UP) issue.
Or did I miss something?

Thanks
Hangbin

  reply	other threads:[~2026-10-23  3:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  8:58 [PATCH net v3 1/2] veth: keep carrier off when resizing channels with a down peer Xia Yan
2026-10-22  8:58 ` [PATCH net v3 2/2] selftests: net: check veth carrier after changing channel counts Xia Yan
2026-10-23  1:47   ` Hangbin Liu
2026-10-23  2:33     ` Xia Yan
2026-10-23  3:15       ` Hangbin Liu [this message]
2026-10-23  3:35         ` Xia Yan
2026-10-23  1:56 ` [PATCH net v3 1/2] veth: keep carrier off when resizing channels with a down peer Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atrRQzn2prYbF1vF@fedora \
    --to=hangbin.liu@linux.dev \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=yana06070@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®