From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>,
Nikhil Gautam <nikhilgtr@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Jesper X Nilsson" <jesper.x.nilsson@axis.com>
Subject: Re: [PATCH v1 1/1] iio: light: opt4001: Re-use generic struct s32_fract
Date: Fri, 23 Oct 2026 12:21:36 +0300 [thread overview]
Message-ID: <atsnIMEnefu0GD96@ashevche-desk.local> (raw)
In-Reply-To: <20261023090802.1957593-1-andriy.shevchenko@linux.intel.com>
On Fri, Oct 23, 2026 at 11:08:02AM +0200, Andy Shevchenko wrote:
> Instead of custom data type re-use generic struct s32_fract.
> No functional changes intended.
...
> static const struct opt4001_chip_info opt4001_sot_5x3_info = {
> - .mul = 4375,
> - .div = 10000000,
> + ,ratio = { .numerator = 4375, .denominator = 10000000 },
Oh, I should have compiled it, but I missed. Should start with a period, of
course.
> .name = "opt4001-sot-5x3"
> };
> static const struct opt4001_chip_info opt4001_picostar_info = {
> - .mul = 3125,
> - .div = 10000000,
> + ,ratio = { .numerator = 3125, .denominator = 10000000 },
> .name = "opt4001-picostar"
> };
Ditto.
...
Jesper, please take this patch into your series, but also fix those typos.
Or if you are busy, I can do it after my lunch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-23 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 9:08 Andy Shevchenko
2026-10-23 9:21 ` Andy Shevchenko [this message]
2026-10-23 10:02 ` Jesper X Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atsnIMEnefu0GD96@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jesper.x.nilsson@axis.com \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@oss.qualcomm.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhilgtr@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®