From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jesper X Nilsson <jesper.x.nilsson@axis.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Stefan Windfeldt-Prytz" <stefan.windfeldt-prytz@axis.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH v2 3/4] iio: light: opt4001: refactor driver to prepare to support more devices
Date: Fri, 23 Oct 2026 16:51:40 +0300 [thread overview]
Message-ID: <attmbDFpqyBHV0VW@ashevche-desk.local> (raw)
In-Reply-To: <20261023-opt4041-v2-3-ee320812804c@axis.com>
On Fri, Oct 23, 2026 at 02:30:30PM +0200, Jesper X Nilsson wrote:
> Prepare opt4001 driver to be able to support OPT4041. Extend struct
> opt4001_chip_info with fields channels and device_id because OPT4041 has
> two channels and another device id.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> - ret = regmap_read(chip->regmap, OPT4001_LIGHT1_MSB, &light1);
> + ret = regmap_read(chip->regmap, reg, &light1);
> if (ret < 0) {
> dev_err(dev, "Failed to read data bytes");
> return ret;
> }
>
> - ret = regmap_read(chip->regmap, OPT4001_LIGHT1_LSB, &light2);
> + ret = regmap_read(chip->regmap, reg + 1, &light2);
> if (ret < 0) {
> dev_err(dev, "Failed to read data bytes");
> return ret;
Can it be actually a bulk read? (Not part of this series, I assume.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-23 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 12:30 [PATCH v2 0/4] This series adds support for Texas Instruments OPT4041 Ambient light sensor Jesper X Nilsson
2026-10-23 12:30 ` [PATCH v2 1/4] dt-bindings: iio: light: opt4001: add opt4041 Jesper X Nilsson
2026-10-23 17:37 ` Conor Dooley
2026-10-23 12:30 ` [PATCH v2 2/4] iio: light: opt4001: Re-use generic struct s32_fract Jesper X Nilsson
2026-10-23 12:30 ` [PATCH v2 3/4] iio: light: opt4001: refactor driver to prepare to support more devices Jesper X Nilsson
2026-10-23 13:51 ` Andy Shevchenko [this message]
2026-10-23 12:30 ` [PATCH v2 4/4] iio: light: opt4001: add support for opt4041 Jesper X Nilsson
2026-10-23 13:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=attmbDFpqyBHV0VW@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jesper.x.nilsson@axis.com \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=stefan.windfeldt-prytz@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®