mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Lorena Tanase <tanaselorena3@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, andy@kernel.org,
	gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev,
	Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH] staging: media: atomisp: Fix double blank line
Date: Fri, 23 Oct 2026 16:55:33 +0300	[thread overview]
Message-ID: <attnVU9A2GvgYuy9@ashevche-desk.local> (raw)
In-Reply-To: <20261023123158.6176-1-tanaselorena3@gmail.com>

On Fri, Oct 23, 2026 at 03:31:58PM +0300, Lorena Tanase wrote:
> Removed blank line to ensure linux kernel coding style. Found using
> checkpatch.pl script.

Cool, but is this the only problem in the driver?

> Cc: Daniel Baluta <daniel.baluta@nxp.com>

Please, put the Cc list after the '---' line, so it won't pollute commit
message.

> Signed-off-by: Lorena Tanase <tanaselorena3@gmail.com>
> ---

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-10-23 13:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 12:31 Lorena Tanase
2026-10-23 13:55 ` Andy Shevchenko [this message]
2026-10-23 14:09   ` Daniel Baluta
2026-10-23 16:17     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=attnVU9A2GvgYuy9@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tanaselorena3@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®