mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Ernest Van Hoecke <ernestvanhoecke@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
Subject: Re: [PATCH v3 4/4] arm64: dts: freescale: imx8mp-verdin: Add mezzanine OV5640 overlays
Date: Fri, 23 Oct 2026 15:23:12 -0500	[thread overview]
Message-ID: <atvCMGUsLXImGhxZ@SMW015318> (raw)
In-Reply-To: <zv4gir4qrx62cwyl47cypuk57q7ci4l2piml5cgchhiys2hyli@ubzeh3nw4itu>

On Fri, Oct 23, 2026 at 03:51:17PM +0200, Ernest Van Hoecke wrote:
> On Thu, Oct 22, 2026 at 05:20:48PM -0400, Frank Li wrote:
> > On Thu, Oct 22, 2026 at 04:31:28PM +0200, Ernest Van Hoecke wrote:
> > > From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> > >
> > > The Verdin iMX8M Plus exposes its second MIPI CSI-2 interface through the
> > > Verdin iMX8M Plus Mezzanine. Add overlays for using a Toradex OV5640 camera
> > > on this interface.
> > >
> > > The mezzanine can route the camera control signals through two jumper
> > > configurations. Describe each configuration as a GPIO nexus mapping so the
> > > camera description remains independent of the physical routing.
> > >
> > > The default positions share the native CSI_1 GPIOs and are intended for a
> > > single camera. The alternate positions permit simultaneous native and
> > > mezzanine cameras, but conflict with the Atmel MXT touchscreen GPIO.
> > >
> > > The current camera set uses a 27 MHz on-board oscillator. The legacy camera
> > > module uses 24 MHz, so provide variants for both.
> > >
> > > Link: https://developer.toradex.com/hardware/verdin-som-family/add-ons/verdin-imx8m-plus-mezzanine/
> > > Link: https://developer.toradex.com/hardware/accessories/cameras/csi-camera-module-5mp-ov5640-arducam
> > > Link: https://developer.toradex.com/hardware/legacy-products/other/csi-camera-module-5mp-ov5640/
> > > Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/Makefile             | 19 ++++++
> > >  ...-verdin-mezzanine-ov5640-24mhz-alt-jumpers.dtso | 19 ++++++
> > >  ...din-mezzanine-ov5640-24mhz-default-jumpers.dtso | 18 +++++
> > >  ...imx8mp-verdin-mezzanine-ov5640-alt-jumpers.dtso | 38 +++++++++++
> > >  ...mp-verdin-mezzanine-ov5640-default-jumpers.dtso | 42 ++++++++++++
> > >  .../freescale/imx8mp-verdin-mezzanine-ov5640.dtsi  | 78 ++++++++++++++++++++++
> >
> > why not share with imx8m-verdin-ov5640.dtsi, which is almost the same.
> >
> > Frank
>
> Hi Frank,
>
> Both camera modules have their own oscillator, and the native and
> Mezzanine connectors have their own supply, so each overlay describes its
> own clock and regulator nodes. They also use a different I2C bus, CSI
> receiver and connector. Both overlays are applied together for two
> cameras (imx8mp-verdin-wifi-dev-dual-ov5640),

Okay, I see share one imx8m-verdin-ov5640.dtso

> so their node names and
> labels must be unique, and a single .dtsi cannot be included twice.

mezzanine actually connect by another connectors ? so it need new one files
because current nexus node's limitation.

Can you make imx8mp-verdin-mezzanine-ov5640.dtsi also standardize, like
use unified camera_i2c_2, camera_connector2, compre to imx8m-verdin-ov5640.dtso

And avoid dtso include dtso file.  Now perfer only include dtsi file.

Frank

>
> The connector nexus makes the GPIOs independent of the routing, but an
> overlay still has to name the connector, bus and receiver it uses. One
> overlay for either connector would need the target to be chosen when it
> is applied, which is what the DT connector/addon work is about, so sadly
> we have to wait for that to make things more generic.
>
> What is left in common is a few constant sensor properties, so I would
> like to keep the two files.
>
> Thanks for your input and best regards,
> Ernest
>

      reply	other threads:[~2026-10-23 20:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 14:31 [PATCH v3 0/4] arm64: dts: freescale: Add Verdin iMX8M OV5640 camera overlays Ernest Van Hoecke
2026-10-22 14:31 ` [PATCH v3 1/4] dt-bindings: connector: Add Toradex camera connector Ernest Van Hoecke
2026-10-22 18:13   ` Conor Dooley
2026-10-22 14:31 ` [PATCH v3 2/4] arm64: dts: freescale: imx8m{m,p}-verdin: Add camera connector nexus Ernest Van Hoecke
2026-10-22 21:07   ` Frank Li
2026-10-23 14:05     ` Ernest Van Hoecke
2026-10-22 14:31 ` [PATCH v3 3/4] arm64: dts: freescale: imx8m{m,p}-verdin: Add shared OV5640 overlays Ernest Van Hoecke
2026-10-22 14:31 ` [PATCH v3 4/4] arm64: dts: freescale: imx8mp-verdin: Add mezzanine " Ernest Van Hoecke
2026-10-22 21:20   ` Frank Li
2026-10-23 13:51     ` Ernest Van Hoecke
2026-10-23 20:23       ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atvCMGUsLXImGhxZ@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ernest.vanhoecke@toradex.com \
    --cc=ernestvanhoecke@gmail.com \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®