From: Jarkko Sakkinen <jarkko@kernel.org>
To: Eduard Zateev <hackerowskiy@gmail.com>
Cc: dhowells@redhat.com, paul@paul-moore.com, jmorris@namei.org,
serge@hallyn.com, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+c15de43f1e7fffbb7b9b@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] keys: use long workqueue for garbage collection
Date: Sat, 24 Oct 2026 08:43:49 +0300 [thread overview]
Message-ID: <atxFldwBDvSALp46@kernel.org> (raw)
In-Reply-To: <atxEIlD8yeW30Nwr@kernel.org>
On Sat, Oct 24, 2026 at 08:37:42AM +0300, Jarkko Sakkinen wrote:
> On Sat, Oct 24, 2026 at 08:20:55AM +0300, Jarkko Sakkinen wrote:
> > On Sat, Oct 24, 2026 at 06:29:44AM +0200, Eduard Zateev wrote:
> > > The key garbage collector can wait for RCU grace periods. This can occupy a
> > > normal events worker for a long time and contribute to workqueue lockups.
> > >
> > > Queue key GC on system_long_wq because its work may wait for long periods.
> > >
> > > Reported-by: syzbot+c15de43f1e7fffbb7b9b@syzkaller.appspotmail.com
> > > Link: https://syzkaller.appspot.com/bug?extid=c15de43f1e7fffbb7b9b
> > > Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
> >
> > This commit message is not huge selling point for any possible argument.
>
> You ignored key_gc_timed_out(), which leaves code to a broken state and
> switching workqueue is not solving any possible root cause of anything.
> The long queue exists mostly for the sake of flush_workqueue().
>
> Please stop sending patches like this in the future.
Makes me wonder was this even tried a single time TBH given the obvious
glitch. I would bet for no.
Br, Jarkko
prev parent reply other threads:[~2026-10-24 5:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 4:29 Eduard Zateev
2026-10-24 5:20 ` Jarkko Sakkinen
2026-10-24 5:37 ` Jarkko Sakkinen
2026-10-24 5:43 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atxFldwBDvSALp46@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=hackerowskiy@gmail.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=syzbot+c15de43f1e7fffbb7b9b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®