From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=202.12.124.159 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794084604; b=gJJCsuHjljYiZdujmR7u2co3Ce+qI1eLTqRnYRC7eghsy5lO82eJIM8LXXTvrk82B8hB cQhiCQr7Eej/ApFNhQFVPp0vtOZbdjC++71YmzMfIFD0azP0lyFk5zDijtVn+JhRuKAUd jsaN4lAEWV5XNYr2ZhTvVsSKfTmY38rvlqQLmh8kTlUFpw/QOKU7QmEBidYPZnkN8R46Z F/ULt2FxiFCexDtPSXDIVwF526udrK6agWM9YUGDsn1af6MIluSLxE+wNTFb5jxIgZQuM ofj4AnJpGObGRfaYK8qxFY2Q6bHfW4JympQs95ncxcbwfjTlfwqc6Nuc5ZmXqKswcrw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794084604; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=aOesGKy7Bt1YCMx1QwBRu3MlgUbtfj3W3WMjPklWMRI=; b=NJhlcicx9B0N3xVMS6Xnda+az9BO5iM649RnjAx27f4PQntvjm4biOp42VDrA5G82Hyz 35kjrSmHuAIms9qVM7WfDMOJGGCV1+gET2S/nlcw2EdOiSJjX7FCufpni543asTFMMnpr IJ/b+IQTER7akzomGWk0u3aPoVU49r9ixVFUV4Sa6fTy7CQACASTS3FHac1VdSbJmwF2B VZ6UQ84X/v+4Ym+S/tLu0pk24pbFoICH+9YkSQorjYdyoVRCGZt9/NENFuJ01b02XDWAC SVb5np4OwNIn015vdyzvnsfUT0vRBTNBMiiyBvnSUctnr9Dy5Yqwtzhj3cUAx6RdadA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=joshtriplett.org; spf=pass smtp.mailfrom=joshtriplett.org; dkim=temperror header.d=joshtriplett.org header.i=@joshtriplett.org header.a=rsa-sha256 header.s=fm3 header.b="z6u+N/G2"; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=dthcuLss; arc=none smtp.remote-ip=202.12.124.159 Received: from fhigh-b8-smtp.messagingengine.com (fhigh-b8-smtp.messagingengine.com [202.12.124.159]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF09E606A32C for ; Sat, 7 Nov 2026 20:50:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EF09E606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=joshtriplett.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=joshtriplett.org Authentication-Results: smtp.subspace.kernel.org; dkim=temperror header.d=joshtriplett.org header.i=@joshtriplett.org header.a=rsa-sha256 header.s=fm3 header.b=z6u+N/G2; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=dthcuLss Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id 2D61A7A00F2 for ; Sat, 7 Nov 2026 15:50:03 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Sat, 07 Nov 2026 15:50:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= joshtriplett.org; h=cc:cc:content-transfer-encoding:content-type :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to; s=fm3; t=1794084601; x=1794171001; bh=aOesGKy7Bt1YCMx1QwBRu 3MlgUbtfj3W3WMjPklWMRI=; b=z6u+N/G2KU95qqFq0G5Z9YVJiKgWnQa5G3yvr rYko1LUo1fh8ZyPT4RdiMBwABrTuZaIxpwDdoj0rSsmrWMLvVrug+N/jEfoTiU8W vC5MGEfn8d+GpBZIPw6ZQWjp2T/cUptWMs/FaaqGSZ3nR3g18Zudm19kM2f8JiAn fe7ijTtrDukQMkORYJ+a1P1BeBTkNr/+sx1JBZdavRymrM1EG+1foFsaDYu9MxWt x/dbi3m7A9EoLJDsSRSX+sUrH5cxt9BM82ZB1f8VIlxPDBDCnoOmvLE5bcZR8Ofp pZuep6G/RzDuvxZre+AnDp/Rt+FPI4SDvHtFQIqZ0GtocwujA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1794084601; x= 1794171001; bh=aOesGKy7Bt1YCMx1QwBRu3MlgUbtfj3W3WMjPklWMRI=; b=d thcuLssM+anEFXWbCJArOEynkrI5v1Jg7Fg/dpmuI9sOL/RLzDPI0PpVK5FR0bjN iqKZVEDpyiOlAACLkOzTkhEZI0/5cm80ofdvI0rQ/7IULCv667AN02oEqdidzLdV YweqhfXi9Zzj7kxdW+TNXtoKoHg2mVRQyMNq2P1Uwv2B5FLQm7vuIIcdjWnpsfNM 0EX75KDEjwLhttcVPuDNupZVP5RSeAOTegDHBJfeJC0FAIQG2d5Wq0j8b3SLoJbo PhaFb6NBo0gO4zYs30VnMAQKpNWbdYlnxRBtCxzrBgfLthczNWzISKHRXmVLfaOL epp/7e41dTtvZ4h02DJQw== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=joshtriplett.org a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794084601; d=joshtriplett.org; mf=PGpvc2hAam9zaHRyaXBsZXR0Lm9yZz4=; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm3:rsa-sha256:Hg/4/o6HA+jPdg3H0vzWdTWG1dD3ASjV9VmiJDyhTVOMfbM WSTSbx5BInrSTp6WKyYvnAjP957CHbVBAUM/Fyqw9wcXU/3HlN+eQJQy2yUUhPzH Jpboo8hFi7pZn/OZhR4s92q1hbDo75IRuP3i8IJQJYvv8lnJcwRXDs0RFqvNo1LT nuZelSmGoLJGKyjsfiTCpR6FeCb8wGfGAUeDMyjtJk0O4DENsxK+zU6zrn+GW8UP zsARiSiI/YfBTOAkufXiu+h/8TC+FV5txexktkAaASsfCFyw0tFAqGapDvolM11p u9S4BHlL6HtqgnL3/9pepo1kbcX/JV5bBImbw/g==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=13; hn=cc,content-disposition,content-transfer-encoding, content-type,date,feedback-id,from,in-reply-to,message-id, mime-version,references,subject,to; Message-Instance: m=1; h=sha256:A19Renz0cxkEDfbt/2pLjrnJSUaI6TuPqDwDKxer6XA=:wyge+1tOzwAIZGqBD066PALFzHGlxq9/uxHhTr4zyrA=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTG1ZfC8HBbsKhJNIVCAtBIJYEcqG93Uh6xOwtCMmcb+hKolNtXgix5VRY7hVx0P8B aYZ1u5MQjSiy0VXR2QRQLjMfSZMQs2XO1jXfVvLxh7OHNABgdwZpfX4CAiUwXmim6Ha2X6 qESHRKysaogslaAs00WB70ATq9CZzYDD2iGoK1R1YqhYAxANrJjL0h3zVAKqPYe/Sh4gBR XzSZ41dqu5S/3HUnGosu8gvQmNE+ZRKEA7klcbk2KCUA055Y5/hwj8heGdpSLR7BWc0iDR rdakdB0fTjSJhj47sYBvPpEp1KSXZ50H3A54OXwlecHRwFRUQc7WLRfCWkpv9DLN30UJY5 J5mqDOj/Qun4Zmx2MvapvFHmGV/iS+qpmWmDZMXraV6rsbFVDuF8jfSX+jei1rAUM0rM1E AjU0fZVGaolYPMwzs806pNedfrALDiobYYQW69xnQmdfuYhP23Vq0wQfbzgSGpHczO+btB x6b79xPE6tN8OkKKerIZ15w1LwiiEkNZG2/7zhTOknvmLMnhxnycxjGwyR8iuhUloF+UOG dfaMb72Q9gjTUw6sXo/6dZdDCF3VBY1SZpVpBxCn/evX8h0/iiOG+xe3/c1ovlgz9Vsjo4 iIjGu/SydrpeS37sanYmyf29Ue7d9CkW5gK9EfjZ172E7+5v1dKYa8K2+mWw X-ME-Proxy: Feedback-ID: i83e94755:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Nov 2026 15:49:59 -0500 (EST) Date: Sat, 7 Nov 2026 12:49:58 -0800 From: Josh Triplett To: Rong Zhang Cc: Mark Pearson , Henrique de Moraes Holschuh , "Derek J. Clark" , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/x86: tpacpi: Mark charging LEDs as safe Message-ID: References: <19f5b65e494ed710a65927311cb68535c87953d3.camel@rong.moe> <20d824152b1a889b636ef9877b4d1a8e06dcf460.camel@rong.moe> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20d824152b1a889b636ef9877b4d1a8e06dcf460.camel@rong.moe> On Sat, Nov 07, 2026 at 07:45:12PM +0800, Rong Zhang wrote: > Hi Josh, > > On Fri, 2026-11-06 at 15:48 -0800, Josh Triplett wrote: > > On Sat, Nov 07, 2026 at 04:48:44AM +0800, Rong Zhang wrote: > > > The term "unsafe LED" exists because LEDs are write-only for software and > > > fire-and-forget for the EC. By taking the control of an unsafe LED, e.g., > > > attaching an LED trigger, any warning signal from the EC can no longer be > > > displayed by the LED. > > > > > > When it comes to battery LEDs, they are definitely unsafe to override. > > > After all, batteries are dangerous things when they malfuction. Thus, I > > > don't think it's suitable to enable it for all users. > > > > Choosing to not report "charging" vs "full" vs "not charging" via LEDs > > (as opposed to on-screen indicators) is not in itself dangerous. If the > > EC has something like "battery is damaged/overheating/exploding" to > > report, it had better do that by some more effective means than blinking > > an LED, or the message is going to be lost. > > This is not in contradiction to the fact that blinking an LED is crucial. Something can simultaneously be crucial and completely ineffective. As mentioned elsewhere in the thread, "immediate shutdown" would be an improvement. Bonus if a message appears on the screen for a few seconds so the user has some idea what's going on, but whether the OS handles that or not, the shutdown would be an improvement. > > I can't comment on what *every* ThinkPad EC would do, but at least on > > this X1 Carbon Gen 11,  > > That's the whole issue. The patch unlocks charging LEDs on all models, > while your ThinkPad can't speak on behalf of other models. If that is the primary concern, would you accept a DMI-identity-based allowlist? - Josh