From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.91 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793950983; b=r375ThZXGF0QCA1oscewKLLcd2Lgjq/ZLX9ICG7eA3ymDskmHyeG31kh4JgoSC8Fch0N HxGFPwNZq+8nRPNIDVtoeVzvPY0deX/rkgEAarliyQup2I0AH9E26KoGThq+sN86Fn4Hi LSeGFGrJVyJF4h5k+ZjvIK+jmfLKLfATA+bMJ9k5gGZhank6gUfe5L3IEN4NAc/v7eoJd sx2mL6VKTz2aYLz8PJHCyL8CYkN15PIXGsbeTIPE+xMdIPPlc17aR0VEINBdxjRG30x8h ZDGo/YgtIGBLVpAiR4OsUh0MutOe61trqgoiAY696XTuV6xmsLa7Ad2r9/qSGVF0eXw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793950983; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=J6SE0s1+Cmv2tEQyGLs4E7WejNQSVW6EagB3ds9ygbQ=; b=g6te4CgjX1lHIrTNF5VdXPfVEqrfFDq9KUngOpj9qo0hXm+f6gSLbRzU/mluPXJG3/4t HcoNHU6ElIG1Z6GkRmOqMu7GmMyWnxzfHWI2Z3KsL0Mp+umxMEwWj3aeFxnQeY/RkKXdM GF8AYJnU/lIknUztrbWeIL2FM3+bjGyrpl0+mGQ+OsNGusGSNyQMatwOlcvM42ggM2gkl H2WzyE7hsCVqOqQD8+7uXWK2JRmAUXsZIeCDKkUP7AAyI770Qqv8TtiuiouK69g7VijCm bEIp4w9Wm8dOqUo77sN5hn7xIkw9IGF5ku1wsh5X1oIJQ/sNbJrDYEkXNGTw/qfJMtA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=fxlM84s3; arc=none smtp.remote-ip=95.215.58.91 Received: from mta1.migadu.com (out-91.mta1.migadu.com [95.215.58.91]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D68A3606A336 for ; Fri, 6 Nov 2026 07:42:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D68A3606A336 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=fxlM84s3 X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=PtWTq6nqlzK8T9nMNNfK0YJy8biQ9MHHy5p7qGOpMUs=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793950976; v=1; x=1794555776; b=fxlM84s3hCVbROs1wu/ZRrH3w7L69J3djc8r82NKL7XgHLF5bsQqxKfWQvDSAP9wYLmdAde1 mu24woVL/EN8rZQZureXL4U5hLrUQUpSNqcu/ZfylUSqhhED8b7JJPf3XOGbxNYP4nyzo0wgtdF e3L8oaGdTF4l+D2Ofihjjuv4= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta11.migadu.com with ESMTPS id 9c50986a3e384fa4; Fri, 06 Nov 2026 07:42:54 +0000 X-Mizu-Trace-ID: 9c50986a3e384fa4 X-Migadu-Flow: FLOW_OUT Date: Fri, 6 Nov 2026 15:42:19 +0800 From: "Xu Xin (vivo)" To: "Lorenzo Stoakes (ARM)" Cc: Andrew Morton , David Hildenbrand , Jason Gunthorpe , John Hubbard , Peter Xu , "Matthew Wilcox (Oracle)" , Jan Kara , Rik van Riel , "Liam R. Howlett" , Vlastimil Babka , Harry Yoo , Jann Horn , Lance Yang , Zi Yan , Matthew Brost , Joshua Hahn , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Usama Arif , Kiryl Shutsemau , Chengming Zhou , Madhavan Srinivasan , Nicholas Piggin , Michael Ellerman , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , Shrikanth Hegde , Pedro Falcato , Kairui Song , Qi Zheng , Shakeel Butt , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Leon Romanovsky , SJ Park , Rakie Kim , David Rientjes , Alexander Viro , Christian Brauner , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Masami Hiramatsu , Oleg Nesterov , John Johansen , Georgia Garcia , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej =?utf-8?B?TW9zbsOhxI1law==?= , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, damon@lists.linux.dev, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH 06/13] mm/ksm: convert VMA flag tests to use vma_flags_t Message-ID: References: <20261105-late-2026-vma-flags-v1-0-0d3cd15ab75f@kernel.org> <20261105-late-2026-vma-flags-v1-6-0d3cd15ab75f@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105-late-2026-vma-flags-v1-6-0d3cd15ab75f@kernel.org> On Thu, Nov 05, 2026 at 09:30:57PM +0000, Lorenzo Stoakes (ARM) wrote: > Replace use of the legacy vm_flags_t flags with vma_flags_t values where > KSM tests VMA flags directly. > > The ksm_madvise() interface continues to take legacy flags for the time > being. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes (ARM) > --- > mm/ksm.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) LGTM! Thanks! Reviewed-by: Xu Xin (vivo) > > diff --git a/mm/ksm.c b/mm/ksm.c > index d6f736a1aa2f..61b772bba229 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -779,7 +779,7 @@ static struct vm_area_struct *find_mergeable_vma(struct mm_struct *mm, > if (ksm_test_exit(mm)) > return NULL; > vma = vma_lookup(mm, addr); > - if (!vma || !(vma->vm_flags & VM_MERGEABLE) || !vma_has_anon_rmap(vma)) > + if (!vma || !vma_test(vma, VMA_MERGEABLE_BIT) || !vma_has_anon_rmap(vma)) > return NULL; > return vma; > } > @@ -1243,7 +1243,8 @@ static int unmerge_and_remove_all_rmap_items(void) > goto mm_exiting; > > for_each_vma(vmi, vma) { > - if (!(vma->vm_flags & VM_MERGEABLE) || !vma_has_anon_rmap(vma)) > + if (!vma_test(vma, VMA_MERGEABLE_BIT) || > + !vma_has_anon_rmap(vma)) > continue; > err = break_ksm(vma, vma->vm_start, vma->vm_end, false); > if (err) > @@ -2698,7 +2699,7 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page) > goto no_vmas; > > for_each_vma(vmi, vma) { > - if (!(vma->vm_flags & VM_MERGEABLE)) > + if (!vma_test(vma, VMA_MERGEABLE_BIT)) > continue; > if (ksm_scan.address < vma->vm_start) > ksm_scan.address = vma->vm_start; > @@ -2890,7 +2891,7 @@ static int __ksm_del_vma(struct vm_area_struct *vma) > { > int err; > > - if (!(vma->vm_flags & VM_MERGEABLE)) > + if (!vma_test(vma, VMA_MERGEABLE_BIT)) > return 0; > > if (vma_has_anon_rmap(vma)) { > @@ -3027,7 +3028,7 @@ int ksm_madvise(struct vm_area_struct *vma, unsigned long start, > > switch (advice) { > case MADV_MERGEABLE: > - if (vma->vm_flags & VM_MERGEABLE) > + if (vma_test(vma, VMA_MERGEABLE_BIT)) > return 0; > if (!vma_ksm_compatible(vma)) > return 0; > @@ -3484,7 +3485,7 @@ bool ksm_process_mergeable(struct mm_struct *mm) > mmap_assert_locked(mm); > VMA_ITERATOR(vmi, mm, 0); > for_each_vma(vmi, vma) > - if (vma->vm_flags & VM_MERGEABLE) > + if (vma_test(vma, VMA_MERGEABLE_BIT)) > return true; > > return false; > > -- > 2.56.0 >