mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Weijie Yuan <wy@wyuan.org>
To: Dongliang Mu <dzm91@hust.edu.cn>
Cc: Alex Shi <alexs@kernel.org>, Yanteng Si <si.yanteng@linux.dev>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] Update maintainer-pgp-guide.rst Chinese translation
Date: Fri, 6 Nov 2026 16:01:59 +0800	[thread overview]
Message-ID: <au2Jd6oyloqfeXCo@wyuan.org> (raw)
In-Reply-To: <85899751-7554-4014-896a-24bb916c572e@hust.edu.cn>

Dongliang Mu <dzm91@hust.edu.cn> writes:

> 
> On 8/23/26 3:14 PM, Weijie Yuan wrote:
> > The script says:
> > 
> > $ tools/docs/checktransupdate.py Documentation/translations/zh_CN/process/maintainer-pgp-guide.rst
> > [1787244823.341547] Documentation/translations/zh_CN/process/maintainer-pgp-guide.rst
> > [1787244823.630509] commit 54857c52452a ("docs: maintainer-pgp-guide.rst: add a reference for kernel.org sign")
> > [1787244823.680849] commit 6c5c07bc8589 ("docs: process: maintainer-pgp-guide: update kernel.org docs link")
> > [1787244823.730027] commit 273aa250f138 ("Documentation: Improve wording on requirements for a free Nitrokey")
> > [1787244823.779408] commit f44a29784f68 ("Documentation: update maintainer-pgp-guide for latest best practices")
> > [1787244823.779522] 4 commits needs resolving in total
> > 
> > So I updated this document in chronological order, created four patches
> > based on these four outdated commits to make it easier for you to
> > review. Hence, you can freely squash them when applying them.
> 
> I am not sure if we should use "So I updated XXX" in the cover letter
> message.
> 
> From my understanding, it is fine to describe about what you have done and
> why you do this here.

Fine, will notice this.

> > Tested with make cleandocs && make htmldocs, no warning or error made by
> > these patches. (Hope my eyes work fine this time :))
> 
> Haha, LLM can help here.

Ah yes.

> > [+To: Konstantin, as he is the original author, thanks.]
> 
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>

Thanks.

[...]

> > Range-diff versus v1:
> 
> I think this versus is too long to read and it has no much information. In
> the future please do not add such thing in your patches.

Yes, indeed. In our literary work, range-diff may be not that useful
compared with actual codes reviews. So it would be better to just look
at the patch content directly, not range-diff.

Will pay attention this and save our time.

Thanks.

      reply	other threads:[~2026-11-06  8:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23  7:14 Weijie Yuan
2026-08-23  7:14 ` [PATCH v2 1/5] docs/zh_CN: update maintainer-pgp-guide translation Weijie Yuan
2026-08-23  7:14 ` [PATCH v2 2/5] docs/zh_CN: clarify free Nitrokey requirements Weijie Yuan
2026-08-23  7:14 ` [PATCH v2 3/5] docs/zh_CN: update maintainer-pgp-guide kernel.org link Weijie Yuan
2026-08-23  7:15 ` [PATCH v2 4/5] docs/zh_CN: add kernel.org trust repository reference Weijie Yuan
2026-08-23  7:15 ` [PATCH v2 5/5] docs/zh_CN: remove empty proofreader field from maintainer PGP guide Weijie Yuan
2026-11-05 15:20 ` [PATCH v2 0/5] Update maintainer-pgp-guide.rst Chinese translation Dongliang Mu
2026-11-06  8:01   ` Weijie Yuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=au2Jd6oyloqfeXCo@wyuan.org \
    --to=wy@wyuan.org \
    --cc=alexs@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dzm91@hust.edu.cn \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=si.yanteng@linux.dev \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®