From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Sunil Goutham <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Arnd Bergmann <arnd@arndb.de>, Suman Ghosh <sumang@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
Nitin Shetty J <nshettyj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
"Michael Bommarito" <michael.bommarito@gmail.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [v2] net: octeontx2: fix building without DEBUGFS
Date: Fri, 6 Nov 2026 13:42:28 +0530 [thread overview]
Message-ID: <au2L7FZlj0uyF9ba@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20261105161945.1658464-1-arnd@kernel.org>
On 2026-11-05 at 21:49:13, Arnd Bergmann (arnd@kernel.org) wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This error came up on my randconfig tests this week:
>
> drivers/net/ethernet/marvell/octeontx2/af/cn20k/debugfs.c: In function 'npc_cn20k_debugfs_init':
> drivers/net/ethernet/marvell/octeontx2/af/cn20k/debugfs.c:392:55: error: 'struct rvu' has no member named 'rvu_dbg'; did you mean 'rvu_dl'?
> 392 | debugfs_create_file("mcam_layout", 0444, rvu->rvu_dbg.npc,
>
> The problem here is that the rvu_dbg member is hidden in an #ifdef
> block, but the reference to it is not.
>
> Remove the #ifdef and waste a few bytes in the structure in this
> config. Note that the debugfs_create_file() call end up ignoring
> the arguments, so the actual debugfs implementation is still
> ignored here.
>
> Fixes: 528530dff56b ("octeontx2-af: npc: cn20k: add debugfs support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Ratheesh Kannoth <rkannoth@marvell.com>
prev parent reply other threads:[~2026-11-06 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 16:19 Arnd Bergmann
2026-11-06 8:12 ` Ratheesh Kannoth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au2L7FZlj0uyF9ba@rkannoth-OptiPlex-7090 \
--to=rkannoth@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kirankumark@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.bommarito@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nshettyj@marvell.com \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®