From: Breno Leitao <leitao@debian.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Ali Tariq <alitariq45892@gmail.com>,
netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Yixun Lan <dlan@kernel.org>,
Vivian Wang <wangruikang@iscas.ac.cn>,
Chukun Pan <amadeus@jmu.edu.cn>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Tomas Hlavacek <tmshlvck@gmail.com>,
Muhammad Bilal <meatuni001@gmail.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: spacemit: Hold RTNL lock in emac_resume() and emac_suspend()
Date: Fri, 6 Nov 2026 03:54:14 -0800 [thread overview]
Message-ID: <au2_yS85zJYqOaYm@gmail.com> (raw)
In-Reply-To: <DMO12HWY5N64.2IJ5XMUKM8WWR@linux.spacemit.com>
On Fri, Nov 06, 2026 at 09:41:31AM +0000, Troy Mitchell wrote:
> On Thu, 5 Nov 2026 23:28:31 +0100, Vadim Fedorenko wrote:
> > > This would work, but I am wondering if it would be possible to call
> > > rtnl inside the _open function, when dealing with the PHY? in other
> > > words, shrink the time rtnl is held.
> >
> > +1, especially in emac_open() rtnl is needed only in error path case
>
> emac_open() and emac_stop() are also the driver's .ndo_open and
> .ndo_stop, which the core already calls with RTNL held, see
> Documentation/networking/netdevices.rst +214. Taking rtnl_lock()
> inside them would deadlock on every open and close, so the lock has to
> stay in the PM callbacks.
That makes sense to me.
Reviewed-by: Breno Leitao <leitao@debian.org>
next prev parent reply other threads:[~2026-11-06 11:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 12:34 Ali Tariq
2026-11-05 13:40 ` Breno Leitao
2026-11-05 22:28 ` Vadim Fedorenko
2026-11-06 9:41 ` Troy Mitchell
2026-11-06 11:54 ` Breno Leitao [this message]
2026-11-06 14:28 ` Troy Mitchell
2026-11-06 9:43 ` Troy Mitchell
2026-11-06 10:44 ` Ali Tariq
2026-11-06 14:26 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au2_yS85zJYqOaYm@gmail.com \
--to=leitao@debian.org \
--cc=alitariq45892@gmail.com \
--cc=amadeus@jmu.edu.cn \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dlan@kernel.org \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maxime.chevallier@bootlin.com \
--cc=meatuni001@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s-vadapalli@ti.com \
--cc=spacemit@lists.linux.dev \
--cc=tmshlvck@gmail.com \
--cc=troy.mitchell@linux.spacemit.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®