From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793973019; b=kd3zgUtY7s4WxQ9d3PVpu4JrdzMMhaPhmFQOftT2OX9AypFm4yiiX4bqD/rFreKYr3A2 m6ZTtH0oSVRUwGgxg3KNmCrZhB818EQ7z7v7ojck5NsLCZko6E8cdaA3SUbHwfI9fCzKa iNLMGVHiIfsSqpA/eQ10YeG+rKXigYrx2S1M6WsIsPvSwpioO/HZG85unkwB5veQPNXGl OXc9sBpb+rmhggOC102hMgpW1GBwD88c1281UtIzfsjczx1Km+st21xr9foua0TfWFKpI SAUGVAcEDhZlRknC9R1xuBRY1Ffl87dUEcPLySHx6hGhldSMnJEp4168kL8PEoLqNkw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793973019; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To: X-Spam-Flag:X-Spam-Level:X-Spamd-Result:X-Spam-Score; bh=q9ESeoxc2axeNsRXLbRhvtNOs3u64Vs/IsR+3Ogm2vY=; b=HCwK6jfZ9a0SHD3V9HvXAJZI5Y5eDKsMEFnZ/z/dPL6Ws6v1S8vqPA4uSQTmVeMKI40M Q0bJe3HXz5hguk7oy42gqM+dxFwGCgg0eNCd18edv08G7Hh5HUYeTxFWdVkPB5zSsdT8+ kMf5UdV6yB9JqkyvlAuvPHJfjF6TAhf6FxM1yEGS65uUW8jKb5idgmdmTI29VYHmHoHKz 1clPxbi+xKHy4x8VdnAzM3qAxiNH0aMc1sdPnvIIXamVAnIJYKhfcfhgyRNW6RvIOjR8c d6HpCjC6DUNloB3bZ2cFbP7v4PZnN0sAOG+mbtQFzA7oAZF3hlrht9LQBtFhSSB949w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uNyLqImD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CbMIDbjG; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Gpzlf8gB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1PCIbXGU; arc=none smtp.remote-ip=195.135.223.130 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECDE9606A329; Fri, 6 Nov 2026 13:50:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org ECDE9606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uNyLqImD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CbMIDbjG; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Gpzlf8gB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1PCIbXGU Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1F25C22154; Fri, 6 Nov 2026 13:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1793973017; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q9ESeoxc2axeNsRXLbRhvtNOs3u64Vs/IsR+3Ogm2vY=; b=uNyLqImDHX5uOVHWzgeMclZhQbEhpse/Z2vmgRqvrp5T6T07d6tkR2t1stQFxUA3EhOC6r lpeuo10ir0ehucz4b1zWpIU7fQjhHHJ5t895N9mi5dEFKYGHh7bJdJC5yN2h7kH5+2bsi+ u6ZCJYRpdr4ItxW5JEYexZnc2or9XC0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1793973017; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q9ESeoxc2axeNsRXLbRhvtNOs3u64Vs/IsR+3Ogm2vY=; b=CbMIDbjGYYizk2NtlAxWDcCK/DL2ZKdH4cwLciH/sTjQCuKLF+hsp2giK8raBgUYwm15dP SKl5t7Uafqv0jXCQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1793973016; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q9ESeoxc2axeNsRXLbRhvtNOs3u64Vs/IsR+3Ogm2vY=; b=Gpzlf8gBupkwuEjLYZQim2/w0Pm1DWe7vX27mrWFwxFX5Nm/U1MbOdnF6x8z2smK2DAUWY A9EaopU20S5XLe8GQXAxN3qDrmh6ua6I+BovvBnIzjti9ELEfAE0eIgKo5lmsSej/nM5/n vBOx0TW0lxl8RXmscGS8S4o/ku2ereA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1793973016; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q9ESeoxc2axeNsRXLbRhvtNOs3u64Vs/IsR+3Ogm2vY=; b=1PCIbXGUsJP/R+j/iM9waFtP1LQvuSJhoIFrgr57FV2V116bXLSY15leCUqZzwgmVVkNgr nOKpwWr0IfLvXvBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C7106136CC; Fri, 6 Nov 2026 13:50:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dNaYGRbb7WpeSwAAD6G6ig (envelope-from ); Fri, 06 Nov 2026 13:50:14 +0000 Date: Fri, 6 Nov 2026 13:50:12 +0000 From: Pedro Falcato To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Zi Yan , Baolin Wang , Hugh Dickins , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Zach O'Keefe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chris Mason , stable@vger.kernel.org Subject: Re: [PATCH] mm/khugepaged: don't map folios that are not uptodate in MADV_COLLAPSE Message-ID: References: <20261105-set_huge_pmd_uptodate-v1-1-a78d8a1b7117@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105-set_huge_pmd_uptodate-v1-1-a78d8a1b7117@kernel.org> X-Spam-Flag: NO X-Spam-Level: X-Spamd-Result: default: False [-13.30 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[18]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email] X-Spam-Score: -13.30 On Thu, Nov 05, 2026 at 07:16:44PM +0100, David Hildenbrand (Arm) wrote: > madvise(MADV_COLLAPSE) can map PMD-sized pagecache folios that are not > uptodate. For example, shmem fallocate() can put such folios into the > page cache. > > collapse_file() already refuses to proceed with folios that are not > uptodate. Let's just do the same in try_collapse_pte_mapped_thp() and skip > such folios, leaving handling to the page faults. > > Note that collapse_file() effectively clears shmem folios through > shmem_get_folio(); let's keep this fix simple and simply let the page > fault path deal with that. > > Fixes: 34488399fa08 ("mm/madvise: add file and shmem support to MADV_COLLAPSE") > Reported-by: Chris Mason > Cc: stable@vger.kernel.org > Signed-off-by: David Hildenbrand (Arm) Reviewed-by: Pedro Falcato -- Pedro